fix: show checkbox with multiselect #19665

montelaidev · 2025-09-12T13:52:51Z

Description

This PR shows checkboxes when selecting accounts in the bip 44 edit accounts screen in the dapp connection flow.

Changelog

CHANGELOG entry: Display checkboxes in bip44 edit accounts in the dapp connection flow.

Related issues

Fixes:

Manual testing steps

Feature: edit accounts in the dapp conenction flow. 

  Scenario: user is selecting accounts during dapp connection
    Given the user has state 2 activated.

    When user clicks to connect to a dapp
    Then the account connect flow is show
    Then the user clicks on edit accounts
    and the user will see checkboxes in the account list.

Screenshots/Recordings

Before

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-09-12.at.21.50.56.mp4

After

@

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-09-12.at.21.49.54.mp4

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-09-12T13:52:59Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…accounts

github-actions · 2025-09-15T06:45:26Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 08127ea
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0d1f9337-45bb-4c8f-bbcc-be77e4e446ae

Note

You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the run-ios-e2e-smoke label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2025-09-15T09:02:05Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2a66be0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5026d88a-08e8-4210-9b71-1c4557d1a292

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the run-ios-e2e-smoke label on the pull request

...mp/MultichainAccounts/MultichainAccountSelectorList/AccountListCell/AccountListCell.test.tsx

...temp/MultichainAccounts/MultichainAccountSelectorList/MultichainAccountSelectorList.test.tsx

…accounts

owencraston · 2025-09-17T17:42:51Z

This screen seems to having a lot of performance issues. When I click the different accounts to select them, it takes a few seconds to render.

owencraston · 2025-09-17T17:56:05Z

@montelaidev I noticed the list gets slower as you connect more and more accounts. I also noticed the list kept scrolling back to the initial position but I believe that will be solved in my PR here.

screen-20250917-130830.1.mp4

I also used the why-did-you-render tool to inspect prop changes and I was seeing a lot. I recommend you do the same by setting export ENABLE_WHY_DID_YOU_RENDER="true" in your .js.env and then pressing j in the terminal to open up the console.

below is a video of the why-did-you-render logs when updating the connected accounts (as seen from the phone in the above video)

Screen.Recording.2025-09-17.at.1.49.39.PM.mov

owencraston · 2025-09-17T17:57:09Z

...ts-temp/MultichainAccounts/MultichainAccountSelectorList/AccountListCell/AccountListCell.tsx

      >
        <AccountCell
+          startAccessory={
+            showCheckbox ? (


should we extract this into its own component?

owencraston

Approving despite the performance issues since I feel that we can get a better read on this after I merge one of my changes.

github-actions · 2025-09-17T23:48:04Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 58fd801
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/85acd129-01ff-4441-8b0a-e00c80d18775

Note

You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the run-ios-e2e-smoke label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

sonarqubecloud · 2025-09-18T00:50:01Z

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

fix: show checkbox with multiselect

7921322

montelaidev self-assigned this Sep 12, 2025

montelaidev requested a review from a team as a code owner September 12, 2025 13:52

montelaidev added e2e-test No QA Needed Apply this label when your PR does not need any QA effort. labels Sep 12, 2025

This comment was marked as outdated.

Sign in to view

Merge remote-tracking branch 'origin/main' into fix/checkbox-in-edit-…

302d8e9

…accounts

github-actions bot added the size-M label Sep 12, 2025

This comment was marked as outdated.

Sign in to view

fix: lint

7d1f85d

This comment was marked as outdated.

Sign in to view

montelaidev added the team-accounts-framework Accounts Framework team label Sep 12, 2025

montelaidev added 2 commits September 12, 2025 22:31

fix: test

039973f

fix: prop error

465eea1

montelaidev enabled auto-merge September 12, 2025 14:42

fix: test

8b46b69

This comment was marked as outdated.

Sign in to view

montelaidev added 2 commits September 12, 2025 23:31

fix:lint

1e5962f

fix:test

08127ea

This comment was marked as outdated.

Sign in to view

montelaidev added the run-ios-e2e-smoke Trigger iOS E2E tests on BitRise label Sep 15, 2025

fix: lint and snapshot

2a66be0

montelaidev added run-ios-e2e-smoke Trigger iOS E2E tests on BitRise and removed run-ios-e2e-smoke Trigger iOS E2E tests on BitRise labels Sep 15, 2025

metamaskbot added the bitrise-result-ready label Sep 15, 2025

github-actions bot removed the bitrise-result-ready label Sep 15, 2025

PatrykLucka reviewed Sep 17, 2025

View reviewed changes

...mp/MultichainAccounts/MultichainAccountSelectorList/AccountListCell/AccountListCell.test.tsx Outdated Show resolved Hide resolved

PatrykLucka reviewed Sep 17, 2025

View reviewed changes

...mp/MultichainAccounts/MultichainAccountSelectorList/AccountListCell/AccountListCell.test.tsx Outdated Show resolved Hide resolved

PatrykLucka reviewed Sep 17, 2025

View reviewed changes

...temp/MultichainAccounts/MultichainAccountSelectorList/MultichainAccountSelectorList.test.tsx Outdated Show resolved Hide resolved

montelaidev added 6 commits September 17, 2025 17:10

Merge remote-tracking branch 'origin/main' into fix/checkbox-in-edit-…

79fa9a6

…accounts

fix: tests

4b62388

Merge remote-tracking branch 'origin/main' into fix/checkbox-in-edit-…

29e3f2a

…accounts

fix: test

e19ce79

fix: update testid

8032886

fix: test

58fd801

owencraston reviewed Sep 17, 2025

View reviewed changes

owencraston approved these changes Sep 17, 2025

View reviewed changes

montelaidev added run-ios-e2e-smoke Trigger iOS E2E tests on BitRise and removed run-ios-e2e-smoke Trigger iOS E2E tests on BitRise labels Sep 17, 2025

montelaidev added the Run Smoke E2E Requires smoke E2E testing label Sep 17, 2025

Merge branch 'main' into fix/checkbox-in-edit-accounts

6ae0e0e

montelaidev added Run Smoke E2E Requires smoke E2E testing and removed run-ios-e2e-smoke Trigger iOS E2E tests on BitRise Run Smoke E2E Requires smoke E2E testing labels Sep 18, 2025

montelaidev added this pull request to the merge queue Sep 18, 2025

Merged via the queue into main with commit 02a2f55 Sep 18, 2025
102 of 103 checks passed

montelaidev deleted the fix/checkbox-in-edit-accounts branch September 18, 2025 07:48

github-actions bot locked and limited conversation to collaborators Sep 18, 2025

metamaskbot added the release-7.57.0 Issue or pull request that will be included in release 7.57.0 label Sep 18, 2025

Uh oh!

fix: show checkbox with multiselect #19665

fix: show checkbox with multiselect #19665

Conversation

montelaidev commented Sep 12, 2025

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Sep 12, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions bot commented Sep 15, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

github-actions bot commented Sep 15, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

Uh oh!

Uh oh!

Uh oh!

owencraston commented Sep 17, 2025

Uh oh!

owencraston commented Sep 17, 2025

Uh oh!

owencraston Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

owencraston left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 17, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

sonarqubecloud bot commented Sep 18, 2025

Quality Gate passed

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Sep 15, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Sep 15, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Sep 17, 2025 •

edited by metamaskbot

Loading