Skip to content

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Sep 15, 2025

Description

fix in currency conversion and display on amount page

Changelog

CHANGELOG entry:

Related issues

Fixes: #19673
Fixes: #19697
Fixes: #19669
Fixes: #19702
Fixes: #19704
Fixes: #19709
Fixes: #19698

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

TODO

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri requested a review from a team as a code owner September 15, 2025 04:23
@jpuri jpuri added No QA Needed Apply this label when your PR does not need any QA effort. No E2E Smoke Needed If the PR does not need E2E smoke test run team-confirmations Push issues to confirmations team labels Sep 15, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

cursor[bot]

This comment was marked as outdated.

@github-actions github-actions bot added size-L and removed size-M labels Sep 15, 2025
@jpuri jpuri enabled auto-merge September 15, 2025 06:36
cursor[bot]

This comment was marked as outdated.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 89.01099% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.45%. Comparing base (f075fc2) to head (c364692).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...ws/confirmations/components/send/amount/amount.tsx 83.33% 1 Missing and 2 partials ⚠️
...nents/Views/confirmations/hooks/send/useBalance.ts 80.00% 1 Missing and 2 partials ⚠️
...mations/components/send/amount/animated-cursor.tsx 85.71% 1 Missing and 1 partial ⚠️
...confirmations/hooks/send/useCurrencyConversions.ts 66.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19729      +/-   ##
==========================================
+ Coverage   76.42%   76.45%   +0.03%     
==========================================
  Files        3263     3272       +9     
  Lines       78223    78660     +437     
  Branches    14088    14199     +111     
==========================================
+ Hits        59779    60141     +362     
- Misses      14559    14607      +48     
- Partials     3885     3912      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copy link
Member

@OGPoyraz OGPoyraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all tasks - all looking fine!

@jpuri jpuri added this pull request to the merge queue Sep 15, 2025
Merged via the queue into main with commit 53c2966 Sep 15, 2025
135 of 137 checks passed
@jpuri jpuri deleted the amount_page_fixes branch September 15, 2025 12:28
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2025
@metamaskbot metamaskbot added the release-7.56.0 Issue or pull request that will be included in release 7.56.0 label Sep 15, 2025
@jpuri jpuri changed the title fix: currency conversion and display on amount page fix: cp-7.55.0 currency conversion and display on amount page Sep 15, 2025
@metamaskbot metamaskbot added release-7.55.0 Issue or pull request that will be included in release 7.55.0 and removed release-7.56.0 Issue or pull request that will be included in release 7.56.0 labels Sep 16, 2025
@metamaskbot
Copy link
Collaborator

Missing release label release-7.55.0 on PR. Adding release label release-7.55.0 on PR and removing other release labels(release-7.56.0), as PR was cherry-picked in branch 7.55.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.55.0 Issue or pull request that will be included in release 7.55.0 size-L team-confirmations Push issues to confirmations team
Projects
None yet
5 participants