fix: drop Node 18 support, require Node 20+ (WAPI-1133)#76
Open
chakra-guy wants to merge 1 commit intomainfrom
Open
fix: drop Node 18 support, require Node 20+ (WAPI-1133)#76chakra-guy wants to merge 1 commit intomainfrom
chakra-guy wants to merge 1 commit intomainfrom
Conversation
Node 18 reached end-of-life in April 2025 and lacks globalThis.crypto, forcing unnecessary runtime fallbacks. All production runtimes (browsers, React Native, Node 20+ LTS) already provide this API, and eciesjs 0.4.16 has already dropped Node 18 support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lint-build-test.ymlengines.node >= 20to rootpackage.jsonand all 3 published packages (core,dapp-client,wallet-client) so npm warns consumers on unsupported versions.nvmrcfromv18tov20so contributors get the right version vianvm useREADME.mdprerequisites from "18.x or later" to "20.x or later"Test plan
yarn buildpassesyarn test:unitpasses (59/59)yarn lint:cipasses (no new warnings)yarn biome check ./packagespassesNote
Low Risk
Low risk: this is a tooling/runtime support change (Node 18 -> 20) with no functional code changes, but it may break local dev/consumer installs still pinned to Node 18.
Overview
Drops Node 18 support and standardizes the repo on Node 20+.
CI now runs all
lint,build,test, and changelog validation jobs on Node20.x,.nvmrcis bumped tov20, the README prerequisite is updated, andengines.nodeis set to>=20in the root and all published packagepackage.jsonfiles to warn/enforce supported runtimes.Written by Cursor Bugbot for commit 6b03144. This will update automatically on new commits. Configure here.