Open
Conversation
- Pin eciesjs from ^0.4.15 to exact 0.4.17 in all packages and apps (core, web-demo, rn-demo, integration-tests, load-tests) - No source code changes needed (already using 0.4.x APIs) Part of cross-repo eciesjs version alignment effort with metamask-mobile and connect-monorepo.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin eciesjs from
^0.4.15to exact0.4.17in all packages and apps (core, web-demo, rn-demo, integration-tests, load-tests).No source code changes needed - all KeyManager implementations already use the 0.4.x API correctly.
Why
Cross-repo eciesjs version alignment effort. All three repos that share the ECIES encryption channel (metamask-mobile, connect-monorepo, mobile-wallet-protocol) should use the identical eciesjs version to eliminate any possibility of version-related surprises.
Companion PRs:
Changes
packages/core/package.json(devDependency)apps/web-demo/package.jsonapps/rn-demo/package.jsonapps/integration-tests/package.jsonapps/load-tests/package.jsonAll:
"^0.4.15"->"0.4.17"Test plan
yarn buildpassesyarn testpasses (59 unit tests)yarn lintpassesNote
Low Risk
Dependency-only change that pins
eciesjs(and updates its lockfile transitive deps), with no source code modifications; risk is limited to potential runtime/crypto behavior differences from the patch upgrade.Overview
Pins
eciesjsfrom^0.4.15to exact0.4.17across the monorepo (core, demos, and test apps) to ensure consistent ECIES dependency resolution.Updates
yarn.lockaccordingly, including bumped transitive packages like@ecies/ciphersand@noble/curves.Written by Cursor Bugbot for commit b117c33. This will update automatically on new commits. Configure here.