fix: Restore kernel-browser-runtime sourcemaps in extension - #575
Merged
Conversation
rekmarks
force-pushed
the
rekm/fix-extension-sourcemaps
branch
from
July 8, 2025 22:50
519b11e to
2e4e4ea
Compare
rekmarks
marked this pull request as ready for review
July 8, 2025 23:14
Member
Author
|
@FUDCo you should try out this branch and see if it restores debuggability. |
rekmarks
enabled auto-merge (squash)
July 8, 2025 23:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we introduced the
kernel-browser-runtimepackage, we effectively broke debugging the kernel by breaking its sourcemaps. This happened because we copied its build output (also from Vite) usingvite-plugin-static-copy. To fix this, this PR modifies the extensionvite.config.tsto buildkernel-browser-runtimedirectly.A bigger mystery is why Vite doesn't pull in the sourcemaps of bundled dependencies that ship them. The symptom of this is that we see transpiled
.jsand.mjsfiles in the debugger rather than original sources. However, this is still a significant improvement over the status quo, and we can address the larger sourcemap problem later.