Skip to content

Comments

feat: update bitcoindevkit dependency#579

Open
Battambang wants to merge 2 commits intomainfrom
feat/bitcoindevkit
Open

feat: update bitcoindevkit dependency#579
Battambang wants to merge 2 commits intomainfrom
feat/bitcoindevkit

Conversation

@Battambang
Copy link
Contributor

@Battambang Battambang commented Feb 3, 2026

Note

Medium Risk
Wide dependency swap across wallet, transaction, and validation layers; behavior should be mostly equivalent but subtle API/serialization differences in the new BDK package could affect PSBT/address handling and chain interactions.

Overview
Updates the Snap’s Bitcoin Dev Kit dependency by replacing @metamask/bitcoindevkit with @bitcoindevkit/bdk-wallet-web throughout the codebase (entities, handlers, infra adapters, JSX views, and tests), including updating Jest mocks accordingly.

Refreshes lockfile entries and bumps the Snap manifest shasum to match the rebuilt bundle.

Written by Cursor Bugbot for commit 34353f0. This will update automatically on new commits. Configure here.

@Battambang Battambang requested a review from a team as a code owner February 3, 2026 15:43
@socket-security
Copy link

socket-security bot commented Feb 3, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​bitcoindevkit/​bdk-wallet-web@​0.2.0771009983100

View full report

@socket-security
Copy link

socket-security bot commented Feb 3, 2026

Caution

MetaMask internal reviewing guidelines:

  • Do not ignore-all
  • Each alert has instructions on how to review if you don't know what it means. If lost, ask your Security Liaison or the supply-chain group
  • Copy-paste ignore lines for specific packages or a group of one kind with a note on what research you did to deem it safe.
    @SocketSecurity ignore npm/PACKAGE@VERSION
Action Severity Alert  (click "▶" to expand/collapse)
Block Medium
Network access: npm @bitcoindevkit/bdk-wallet-web in module globalThis["fetch"]

Module: globalThis["fetch"]

Location: Package overview

From: packages/snap/package.jsonnpm/@bitcoindevkit/bdk-wallet-web@0.2.0

ℹ Read more on: This package | This alert | What is network access?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@bitcoindevkit/bdk-wallet-web@0.2.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@darioAnongba
Copy link
Contributor

Hi all, thanks for updating to the official bitcoindevkit package bdk-wallet-web. The current version has some improvements over the archived MetaMask one but is still far from having all the BDK features. It currently support bdk v1 but will soon support bdk v2.

One of the features it will include apart from general improvements from the underlying lib is support for dust checks. Currently the Snap verifies dust manually by having some hardcoded values in validation.ts, you'll be able to replace that with validation from bdk-wallet-web like the rest of the bitcoin validations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants