Skip to content

[Ready for Review] - Adding a concept TOC for Create prerequisites #126069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

aashish1987
Copy link

Work is in progress. Please do not review.
This document explains the prerequisites needed to use Machine Configuration policies.

Work is in progress. Please do not review.
This document explains the prerequisites needed to use Machine Configuration policies.
Copy link
Contributor

@aashish1987 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

@aashish1987 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 6ea6345:

✅ Validation status: passed

File Status Preview URL Details
articles/governance/machine-configuration/concepts/prerequisites.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@v-dirichards v-dirichards added the aq-pr-triaged tracking label for the PR review team label Mar 4, 2025
…ed for Machine Configuration policies to work successfully.
@aashish1987 aashish1987 changed the title [Do Not Review] Create prerequisites.md [Ready for Review] - Adding a concept TOC for Create prerequisites Mar 11, 2025
Copy link
Contributor

Learn Build status updates of commit bee7e8b:

✅ Validation status: passed

File Status Preview URL Details
articles/governance/machine-configuration/concepts/prerequisites.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
File Change Percent This PR contains file(s) with more than 30% file change.

Copy link
Contributor

@michaeltlombardi michaeltlombardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if this article should point users to the Azure Machine Configuration extension article, which lists further prerequisites/considerations.

I'm not sure that the information in this PR on its own requires a separate article, but colocating it with the network and other prerequisites would probably make for a really useful article.

Fixed PR comments.
Copy link
Contributor

Learn Build status updates of commit cd18257:

⚠️ Validation status: warnings

File Status Preview URL Details
articles/governance/machine-configuration/concepts/prerequisites.md ⚠️Warning Details

articles/governance/machine-configuration/concepts/prerequisites.md

  • Line 1, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
  • Line 1, Column 1: [Warning: ms-topic-missing - See documentation] Missing required attribute: 'ms.topic'.
  • Line 2, Column 1: [Warning: code-block-indented - See documentation] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
  • Line 1, Column 1: [Suggestion: ms-date-missing - See documentation] Missing required attribute: 'ms.date'.
  • Line 1, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@@ -0,0 +1,9 @@
# Prerequisites to use Machine Configuration Policies
Copy link
Contributor

@michaeltlombardi michaeltlombardi Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Prerequisites to use Machine Configuration Policies
---
title: Prerequisites to use Machine Configuration Policies
description: Describes steps required for using Machine Configuration.
ms.date: 04/01/2025
ms.topic: conceptual
---
# Prerequisites to use Machine Configuration Policies

Comment on lines +2 to +3
To ensure that Machine Configuration policies can be applied successfully, certain prerequisites must be met. This document outlines the necessary steps and considerations for deploying these prerequisites.
The following prerequisites are needed for Machine Configuration policies to work.
Copy link
Contributor

@michaeltlombardi michaeltlombardi Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To ensure that Machine Configuration policies can be applied successfully, certain prerequisites must be met. This document outlines the necessary steps and considerations for deploying these prerequisites.
The following prerequisites are needed for Machine Configuration policies to work.
To ensure that Machine Configuration policies can be applied successfully, certain prerequisites
must be met. This document outlines the necessary steps and considerations for deploying these
prerequisites.
The following prerequisites are needed for Machine Configuration policies to work:

Comment on lines +8 to +9
Machine Configuration provides an initiative which will help to achieve all the above prerequisites.
Please assign this built-in initiative at the scope you are planning to use Machine Configuration policies - *Deploy prerequisites to enable Guest Configuration policies on virtual machines*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Machine Configuration provides an initiative which will help to achieve all the above prerequisites.
Please assign this built-in initiative at the scope you are planning to use Machine Configuration policies - *Deploy prerequisites to enable Guest Configuration policies on virtual machines*
To automatically fulfill these prerequisites, you can use the **Deploy prerequisites to enable
Guest Configuration policies on virtual machines** built-in initiative. Assign the initiative at
the scope you're planning to use Machine Configuration policies.

Copy link
Contributor

@michaeltlombardi michaeltlombardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last changes for formatting and slight rewording. If you use the UI on the "Files changed" tab, you can batch-add these suggestions and commit them.

I think you also need to add this article to the TOC.

@michaeltlombardi
Copy link
Contributor

@aashish1987 - wondering if you can review and incorporate the feedback so we can close this out.

@v-ccolin
Copy link
Contributor

v-ccolin commented May 1, 2025

I sent an email to the content owner today.

@MicrosoftDocs/public-repo-pr-review-team

@v-dirichards
Copy link
Contributor

@ttorble
Copy link
Contributor

ttorble commented May 30, 2025

I emailed the (internal) contributor today.

@v-dirichards
Copy link
Contributor

@michaeltlombardi

Can you review this old PR and determine whether it needs to be closed or merged?

@MicrosoftDocs/public-repo-pr-review-team

@v-dirichards
Copy link
Contributor

@aashish1987 Could you respond to these comments?

#126069 (comment)
#126069 (comment)
#126069 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants