Skip to content

Conversation

MilesCranmer
Copy link
Owner

@MilesCranmer MilesCranmer commented Jan 2, 2025

This adds the cluster_manager="slurm_native" option which uses https://github.com/kleinhenz/SlurmClusterManager.jl. The idea with this is that you could potentially just have

sbatch -N 2 --ntasks-per-node=64 search.py

and it will "just work" and set up the search over the cluster. This is the much more standard way to use slurm. This will get the right slurm configurations from the environment variables.

TODO:

  • Do a multi-node test. Maybe @wkharold would be interested in testing too?
  • Set up heap size hint We don't actually need to do this! Since slurm will partition the memory for us and each Julia process will be aware.
  • Add a detailed example to docs for how to set this up.

@coveralls
Copy link

coveralls commented Jan 2, 2025

Pull Request Test Coverage Report for Build 13483409665

Details

  • 11 of 26 (42.31%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 92.664%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pysr/sr.py 0 1 0.0%
pysr/julia_extensions.py 9 14 64.29%
pysr/julia_helpers.py 2 11 18.18%
Totals Coverage Status
Change from base Build 13478272092: -0.7%
Covered Lines: 1440
Relevant Lines: 1554

💛 - Coveralls

@MilesCranmer
Copy link
Owner Author

MilesCranmer commented Jan 14, 2025

@DilumAluthge
Copy link
Contributor

I should hopefully be able to get the remaining upstream work done soon-ish.

@MilesCranmer
Copy link
Owner Author

Awesome. Thanks!

@MilesCranmer MilesCranmer force-pushed the fix-cluster-manager branch from 0a133c9 to 88554ce Compare May 22, 2025 00:56
Copy link

codecov bot commented May 22, 2025

Codecov Report

Attention: Patch coverage is 42.30769% with 15 lines in your changes missing coverage. Please review.

Project coverage is 92.84%. Comparing base (a23b847) to head (88554ce).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
pysr/julia_helpers.py 18.18% 9 Missing ⚠️
pysr/julia_extensions.py 64.28% 5 Missing ⚠️
pysr/sr.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #794      +/-   ##
==========================================
- Coverage   93.54%   92.84%   -0.70%     
==========================================
  Files          21       21              
  Lines        1565     1580      +15     
==========================================
+ Hits         1464     1467       +3     
- Misses        101      113      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants