minor changes to blocks #63
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
These are my thoughts on some of the high level stuff, it's up to you @GoldenStack if you want to address my comments or ask @Garrett-EMS to
blocks/src/main/java/net/minestom/vanilla/fluids/MinestomFluids.java
Outdated
Show resolved
Hide resolved
| public class FluidUtils { | ||
|
|
||
| public static Point raycastForFluid(Player player, Point startPosition, Vec direction, double maxDistance) { | ||
| Point currentPosition = startPosition; |
There was a problem hiding this comment.
You should be able to do a sweep cast here as opposed to an approximation.
IIRC it's something like boundingBox.sweep().
BlockIterators might also be useful.
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
Why are there these random resource json files?
You should be able to extract these from the datapack instead.
| * Interface for tag providers that check if elements are tagged and can return sets of elements with specific tags | ||
| * @param <T> The type of element being tagged | ||
| */ | ||
| public interface TagProvider<T> { |
There was a problem hiding this comment.
We should remove this in favor of our current tags system, or merge/replace it into our current tag system.
Ideally all these tags should be fetched from the datapack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
port blocks n stuff to java from kotlin