Allow data_generator.py to run without requiring classical datasets for custom datasets #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zed data Previously, users needed to download classical datasets even when using their own custom datasets. This update removes that requirement, enabling the code to work solely with user-provided datasets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates adbench/datasets/data_generator.py so that users who want to use their own customized datasets no longer need to download or have the classical datasets beforehand. Previously, the code required classical datasets to be present even if they weren't needed, which could be inconvenient for users working exclusively with custom data.
With this change, the data generator will skip the classical dataset dependency when custom datasets are provided, improving usability and flexibility.