2123 Fix endpoint_url when use_apigateway is false#2124
Open
jwilges wants to merge 2 commits intoMiserlou:masterfrom
Open
2123 Fix endpoint_url when use_apigateway is false#2124jwilges wants to merge 2 commits intoMiserlou:masterfrom
endpoint_url when use_apigateway is false#2124jwilges wants to merge 2 commits intoMiserlou:masterfrom
Conversation
Author
|
Hi @jneves, since you appear to be the sole life-blood for pull requests as of late, would you be able to take a look at this and let me know what you think? I have deployed and tested this with our Lambdas by pinning:
I know this is probably annoying to check into, so I tried to provide a reasonable tag to pin and test against to make your life easier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update no longer raises an exception while updating
endpoint_urlwithbase_pathwhenuse_apigatewayisFalse.Further, when
use_apigatewayisFalse, update now also:deployed_stringwithendpoint_url(admittedly, Zappa's formatting for this could be improved)GitHub Issues
See issue #2123 for more information and for further discussion.