-
Notifications
You must be signed in to change notification settings - Fork 61
Tutorial - Building 2D Games - Fix circle collision math and a few typos. #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
fd36e14
Fix circle collision math and a few typos.
MikeA1 c6a13f0
Add back "Since this forms a right triangle,"
MikeA1 55bdb68
Use * instead of _
MikeA1 11d6814
Switch circle radii back to 5
MikeA1 889e7c1
Merge branch 'MonoGame:main' into chapter-12-fix
MikeA1 2da7ede
Corrections
SimonDarksideJ File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 10 additions & 9 deletions
19
articles/tutorials/building_2d_games/12_collision_detection/snippets/vector2_distance.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,23 @@ | ||
Vector2 circle1Position = new Vector2(8, 10); | ||
Vector2 circle2Position = new Vector2(5, 6); | ||
|
||
float circle1Radius = 5; | ||
float circle2Radius = 5; | ||
float circle1Radius = 3; | ||
float circle2Radius = 3; | ||
SimonDarksideJ marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
// c^2 = a^2 + b^2 | ||
// c^2 = (8 - 5)^2 + (10 - 6)^2 | ||
// c^2 = 3^2 + 4^2 | ||
// c^2 = 9 + 16 | ||
// c^2 = 25 | ||
float distanceSquared = Vector2.DistanceSquared(circle1Position, circle2Position); | ||
float distanceSquared = Vector2.DistanceSquared(circle1Position, circle2Position); | ||
|
||
// r^2 = (5 + 5)^2 | ||
// r^2 = (10)^2 | ||
// r^2 = 100 | ||
int radiiSquared = (circle1Radius + circle2Radius) * (circle1Radius + circle2Radius) | ||
// r^2 = (3 + 3)^2 | ||
// r^2 = (6)^2 | ||
// r^2 = 36 | ||
int radiiSquared = (circle1Radius + circle2Radius) * (circle1Radius + circle2Radius); | ||
|
||
// They do not overlap since 100 is not less than 25 | ||
if(radii < distanceSquared) | ||
// The circles overlap because 36 is greater than 25 | ||
if(radiiSquared > distanceSquared) | ||
{ | ||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.