Add AnimationBuilder::try_insert_tween_here #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maintain a consistent usage pattern, especially when destroying entities.
Owner
|
Could you resolve the conflicts? Thanks. |
Mainly for scenarios where entities may not exist.
Contributor
Author
|
@Multirious please review |
Contributor
Author
|
@Multirious This is update to v0.9.1. Please let me know if any adjustments are needed. Thanks. |
Contributor
Author
|
@Rabbival Could you review this PR? |
Collaborator
That's a lot of line changes and I don't have context. I will read and let you know my thoughts, but it would be helpful if you summerized your changes with such a big PR |
Collaborator
|
Update: I found out (using a diff checker) that github's diff algorithm was being funny. The only new thing in your function is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintain a consistent usage pattern, especially when destroying entities.