Skip to content

[BUGFIX] Use safe file functions in ParserTest #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2025
Merged

[BUGFIX] Use safe file functions in ParserTest #1378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 22 additions & 18 deletions tests/ParserTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@
use Sabberworm\CSS\Value\URL;
use Sabberworm\CSS\Value\ValueList;

use function Safe\file_get_contents;
use function Safe\opendir;

/**
* @covers \Sabberworm\CSS\Parser
*/
Expand Down Expand Up @@ -58,25 +61,26 @@ public function parseForOneDeclarationBlockReturnsDocumentWithOneDeclarationBloc
public function files(): void
{
$directory = __DIR__ . '/fixtures';
if ($directoryHandle = \opendir($directory)) {
/* This is the correct way to loop over the directory. */
while (false !== ($filename = \readdir($directoryHandle))) {
if (\strpos($filename, '.') === 0) {
continue;
}
if (\strrpos($filename, '.css') !== \strlen($filename) - \strlen('.css')) {
continue;
}
if (\strpos($filename, '-') === 0) {
// Either a file which SHOULD fail (at least in strict mode)
// or a future test of an as-of-now missing feature
continue;
}
$parser = new Parser(\file_get_contents($directory . '/' . $filename));
self::assertNotSame('', $parser->parse()->render());
$directoryHandle = opendir($directory);

/* This is the correct way to loop over the directory. */
while (false !== ($filename = \readdir($directoryHandle))) {
if (\strpos($filename, '.') === 0) {
continue;
}
\closedir($directoryHandle);
if (\strrpos($filename, '.css') !== \strlen($filename) - \strlen('.css')) {
continue;
}
if (\strpos($filename, '-') === 0) {
// Either a file which SHOULD fail (at least in strict mode)
// or a future test of an as-of-now missing feature
continue;
}
$parser = new Parser(file_get_contents($directory . '/' . $filename));
self::assertNotSame('', $parser->parse()->render());
}

\closedir($directoryHandle);
}

/**
Expand Down Expand Up @@ -943,7 +947,7 @@ public function missingPropertyValueLenient(): void
public static function parsedStructureForFile($filename, $settings = null): Document
{
$filename = __DIR__ . "/fixtures/$filename.css";
$parser = new Parser(\file_get_contents($filename), $settings);
$parser = new Parser(file_get_contents($filename), $settings);
return $parser->parse();
}

Expand Down