Skip to content

Conversation

@Donien
Copy link
Member

@Donien Donien commented Oct 2, 2025

This PR adds a role for Icinga for Windows (ifw).

The role can install the Icinga PowerShell Framework, manage repositories and components, and configure Icinga 2 via the framework.

@Donien Donien requested a review from losten-git October 2, 2025 12:17
@Donien Donien self-assigned this Oct 2, 2025
Copy link
Member

@dgoetz dgoetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I managed to run in a big problem by adjusting ifw_icinga2_cn from hostname to fqdn which resulted in an installation command which IfW did not like. When running it manually it dropped back to the wizard which is very likely same resulting in a hanging Ansible run. So this should be fixed and requires a time out to prevent such a situation in the future.

Then I would like a design change as current defaults of the role are based on current defaults of IfW which are based on minimum functionality. I would prefer it to use defaults based in best practices as this would give a better user experience and if need for some reason changing back to less would be possible for the user. So I would like to see JEA manageable and by default being enabled and the background daemon being installed and set up so usage of the API is possible resulting in better performance and check results. I am also not sure if we should allow setting the user with the initial release instead of having it as a Todo, especially when adding JEA.

As the Icinga install command might drop to an interactive prompt if
some option is malformed, this timeout ensures that Ansible does not
idle indefinetely.
@Donien
Copy link
Member Author

Donien commented Oct 22, 2025

@dgoetz Please go for another round.

  • Timeout added
  • Installing default components as present now
  • service added to default components
  • JEA added (installed by default)

I also opened an issue regarding being dropped into an interactive menu if the install command is malformed.

Copy link
Member

@dgoetz dgoetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one typo and perhaps some additional documentation, so I already approve.

Password in case of non-service account still needed
@Donien Donien force-pushed the feature/icinga-for-windows branch from 5b4d235 to 406260d Compare October 22, 2025 19:55
@Donien Donien force-pushed the feature/icinga-for-windows branch from ce0ff55 to 9e783ed Compare October 25, 2025 18:11
@Donien Donien force-pushed the feature/icinga-for-windows branch from 9e783ed to 9218c10 Compare October 27, 2025 07:27
@Donien Donien merged commit b56b9c5 into main Oct 27, 2025
9 checks passed
@Donien Donien deleted the feature/icinga-for-windows branch October 27, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants