Fixes #84: Create Drop down Menu in GUI for different lines styles #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djmgit
reviewed
Feb 21, 2018
|
|
||
| self.current_line_style = StringVar(top) | ||
| self.current_line_style.set('-') | ||
| self.line_styles = {'-', '--', '-.', ':'} |
There was a problem hiding this comment.
This shows only symbols in the drop down which looks a bit weird. Please show style names on drop down. Like solid line, dashed, dot dashed. Symbols should be present in bracket.
djmgit
reviewed
Feb 21, 2018
| self.dropdown_menu_line_style = OptionMenu(top, self.current_line_style, | ||
| *self.line_styles, command=self.dropdown_changed_line_style) | ||
| self.dropdown_menu_line_style.pack(side='top', anchor='w') | ||
| self.dropdown_menu_line_style.place(relx=0.78, rely=0.60, height=18, width=100) |
There was a problem hiding this comment.
The position of the drop down is a bit too down. Please move it up a little.
djmgit
reviewed
Feb 21, 2018
| self.dropdown_menu_color.configure(fg=_fgcolorlight) | ||
| self.dropdown_menu_color['menu'].configure(activebackground=_activebgcolordark) | ||
| self.dropdown_menu_color['menu'].configure(background=_bgcolorlight) | ||
| self.dropdown_menu_color['menu'].configure(fg=_fgcolorlight) |
There was a problem hiding this comment.
Dropdown does not change color on changing theme. Please look into this.
djmgit
requested changes
Feb 21, 2018
djmgit
requested changes
Feb 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@djmgit Please review :)