Refactor Stage IC: Move COM and Cycle Variables and Logic from YAML Master Templates to Python Scripts #3984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ando-NOAA/global-workflow into enabler/stage_archive
…ando-NOAA/global-workflow into enabler/stage_archive
| {% endif %} | ||
|
|
||
| {% if ENSMEM == 0 %} | ||
| {% if memdir == 0 %} |
There was a problem hiding this comment.
I don't think this is needed.
ush/python/pygfs/task/stage_ic.py
Outdated
| # assign rRUN to RUN | ||
| case_vars.rRUN = case_vars.RUN | ||
| # case specific rRUN | ||
| if case_vars.RUN in ['gfs', 'gcdas', 'enkfgdas']: |
There was a problem hiding this comment.
Doesn't stage_ic also run on RUN=gdas?
ush/python/pygfs/task/stage_ic.py
Outdated
| if cycle_vars.previous_cycle: | ||
| cycle_vars.previous_cycle_YMD = cycle_vars.previous_cycle.strftime("%Y%m%d") | ||
| cycle_vars.previous_cycle_HH = cycle_vars.previous_cycle.strftime("%H") | ||
| cycle_vars.m_index = cycle_vars.current_cycle.hour // 6 |
There was a problem hiding this comment.
Should 6 be replaced by assim_freq?
| {% set imem = mem - first_mem %} | ||
| {% set COMOUT_ATMOS_ANALYSIS_MEM = COMOUT_ATMOS_ANALYSIS_MEM_list[imem] %} | ||
| {% if DO_JEDIATMVAR %} | ||
| {% for itile in range(6) %} |
There was a problem hiding this comment.
Should probably be replaced by num_tiles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
stage_ic.pyResolves #3946
Type of change
Change characteristics
How has this been tested?
Checklist