[rrfs-mpas-jedi] Change append to prepend for LD_LIBRARY_PATH
#1000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuelDegelia-NOAA
requested review from
BenjaminBlake-NOAA,
JacobCarley-NOAA,
MatthewPyle-NOAA and
ShunLiu-NOAA
as code owners
guoqing-noaa
approved these changes
Oct 9, 2025
|
@SamuelDegelia-NOAA Could you update RDASApp hash in this PR as well? Thanks! |
|
@guoqing-noaa Done! |
ShunLiu-NOAA
approved these changes
Oct 10, 2025
delippi
approved these changes
Oct 10, 2025
|
PS congrats all on lucky PR #1000 |
We need a party to celebrate this! |
Junjun-NOAA
approved these changes
Oct 14, 2025
MatthewPyle-NOAA
approved these changes
Oct 14, 2025
guoqing-noaa
pushed a commit
to guoqing-noaa/rrfs-workflow
that referenced
this pull request
Oct 15, 2025
…Y_PATH` (NOAA-EMC#1000) * change append to prepend for ld_library_path * Update RDASApp hash to develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
This small PR modifies the export statements for
LD_LIBRARY_PATHfrom appends to prepends inworkflow/sideload/launch.sh. This makes the libraries built with RDASApp take precendence over any libraries loaded as part of spack-stack. In particular, this allows us to load the largerjedi-mpas-envbundle that includesgsibecwhile still using thegsibeclibraries built inside RDASApp.This was tested and merged in the RDASApp here.
TESTS CONDUCTED:
Machines/Platforms:
Test cases:
ISSUE:
None
CONTRIBUTORS (optional):
@guoqing-noaa