Print reasoning tokens if VERBOSE logging is enabled#378
Open
niyatisingal wants to merge 2 commits intodevelopfrom
Open
Print reasoning tokens if VERBOSE logging is enabled#378niyatisingal wants to merge 2 commits intodevelopfrom
niyatisingal wants to merge 2 commits intodevelopfrom
Conversation
niyatisingal
force-pushed
the
dev/nsingal/print-reasoning-tokens-in-verbose-logging
branch
6 times, most recently
from
51c1df7 to
1db8d76
Compare
Collaborator
|
When we use model which has reasoning token in like newer nemotron model and I think nemotron nano model. |
Collaborator
Author
yes, this method extract_reasoning_and_content does that. I have called it inside streaming_filter_think methods. |
Signed-off-by: Niyati Singal <nsingal@nvidia.com>
…recated SpanAttributes (#377) Signed-off-by: Swapnil Masurekar <smasurekar@nvidia.com>
niyatisingal
force-pushed
the
dev/nsingal/print-reasoning-tokens-in-verbose-logging
branch
from
1db8d76 to
cae6811
Compare
shubhadeepd
approved these changes
Feb 25, 2026
Collaborator
|
@nv-pranjald please help review this |
nv-pranjald
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
git commit -s) and GPG signed (git commit -S).