fix(tracing): use actual operation timestamps in OpenTelemetry spans #1320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a timing issue in the OpenTelemetry adapter where spans were being created with current timestamps during export instead of using the original timestamps from when operations occurred.
- Modified
_create_span()to usetracer.start_span()with historicalstart_timeandspan.end()with historicalend_time - Updated test cases to verify spans use original operation timestamps
- Added comprehensive timing behavior tests to prevent regression
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
nemoguardrails/tracing/adapters/opentelemetry.py |
Fixed _create_span() to use historical timestamps instead of current time, converting to nanoseconds as required by OpenTelemetry |
tests/test_tracing_adapters_opentelemetry.py |
Updated tests to verify proper timing behavior and removed deprecated import handling |
tests/test_opentelemetry_timing_behavior.py |
Added comprehensive timing tests to verify spans use historical timestamps |
Pouyanpi
force-pushed
the
fix/opentelemetry-span-timing
branch
from
fc840fe to
20fd070
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1320 +/- ##
========================================
Coverage 70.52% 70.53%
========================================
Files 161 161
Lines 16267 16268 +1
========================================
+ Hits 11473 11474 +1
Misses 4794 4794
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Fixes OpenTelemetry tracing issue where spans were created with current timestamps during export rather than original timestamps from when operations actually occurred. Changed from start_as_current_span() to start_span() with proper start_time and span.end() with end_time.
Pouyanpi
force-pushed
the
fix/opentelemetry-span-timing
branch
from
20fd070 to
15aabe4
Compare
|
close in favor of #1331 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OpenTelemetry spans were created with current timestamps during export instead of using he original timestamps from when operations actually occurred.
Fix:
Modified
_create_span()to usetracer.start_span()with originalstart_timeandspan.end()with originalend_timefrom span data, converting timestamps to nanoseconds as required by OpenTelemetry.Test Plan:
tests/test_opentelemetry_timing_behavior.pycontains timing-focused tests that verify spans use original operation timestamps (not current time). This test file is for verification and will be removed after review. The test fails on develop branch.