docs(helm): point KEDA ScaledObject at the quickstart Deployment (NVBug 6622429) - #2602
Open
kheiss-uwzoo wants to merge 1 commit into
Open
docs(helm): point KEDA ScaledObject at the quickstart Deployment (NVBug 6622429)#2602kheiss-uwzoo wants to merge 1 commit into
kheiss-uwzoo wants to merge 1 commit into
Conversation
…ug 6622429) The documented Helm release is retriever, so scaleTargetRef.name must be retriever-nemo-retriever-realtime.
Contributor
Greptile SummaryUpdates the Helm KEDA example so the ScaledObject targets the Deployment rendered by the documented
|
| Filename | Overview |
|---|---|
| nemo_retriever/helm/README.md | The revised KEDA target name and label selectors match the chart’s fullname and role-label helpers. |
Reviews (1): Last reviewed commit: "docs(helm): point KEDA ScaledObject at t..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scaleTargetRef.name: nemo-retriever-realtime, which does not exist for the documented quickstart releaseretriever.retriever-nemo-retriever-realtimeand documents a label-basedkubectlcommand so other release names can discover the rendered realtime Deployment.Test plan
retrieverrendersretriever-nemo-retriever-realtime;nemo-retrieverandcustom-releaseproduce different names.helm template retriever ./nemo_retriever/helmwith the documented KEDA/split flags (Helm is not installed in the authoring environment).kubectl get deploy -l app.kubernetes.io/instance=retriever,app.kubernetes.io/component=realtimereturns the same Deployment name.pre-draft: leakage, mkdocs --strict, ::a, ::p, ::r on the diff vs main
Base: upstream/main
Files: nemo_retriever/helm/README.md
see [CTAs)see [CTAs. The leakage script vsorigin/mainalso scanned stale/untracked leftovers (custom-metadata.md); those files are not in this PR.nemo_retriever/helm/README.md)custom-metadata.md,user-defined-stages.md) that are not in this diff.scaleTargetRef.namematchesnemo-retriever.role.fullnamefor releaseretriever; labels matchnemo-retriever.role.selectorLabels(high confidence).validate_code_blocks.pyreported 0 fences on this file; YAML/bash in the changed section were reviewed manually.Code drift (not in this docs PR): none. Chart templates already derive Deployment names correctly; only the README example was wrong.
PR: this draft