docs(llm): stop claiming NVIDIA_API_KEY is auto-read for nvidia_nim (NVBug 6622594) - #2609
Open
kheiss-uwzoo wants to merge 1 commit into
Open
Conversation
…NVBug 6622594) LiteLLM nvidia_nim reads NVIDIA_NIM_API_KEY. The class docstring now matches the Live RAG examples on main.
kheiss-uwzoo
marked this pull request as ready for review
August 28, 2026 15:20
kheiss-uwzoo
requested review from
drobison00 and
jperez999
and removed request for
drobison00
August 28, 2026 15:20
Contributor
Greptile SummaryUpdates the
|
| Filename | Overview |
|---|---|
| nemo_retriever/src/nemo_retriever/models/llm/clients/litellm.py | The revised credential guidance is consistent with the client’s omitted-key and explicit environment-reference handling; no actionable issue was identified. |
Reviews (1): Last reviewed commit: "docs(llm): stop claiming NVIDIA_API_KEY ..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
api_key="os.environ/NVIDIA_API_KEY", butLiteLLMClientstill claimedNVIDIA_API_KEYwas read automatically.api_keyuses LiteLLM provider-native lookup, thatnvidia_nimreadsNVIDIA_NIM_API_KEY(notNVIDIA_API_KEY), and thatos.environ/NVIDIA_API_KEYforwards the hosted-inference key.Fixes the remaining API-docstring gap on NVBug 6622594.
26.08.1 released artifacts
26.08.1does not contain docs(extraction): pass NVIDIA_API_KEY explicitly in Live RAG examples (NVBug 6622594) #2575. There is no26.08.1maintenance branch to cherry-pick onto.26.8.1publishes frommain, so this docstring (and the already merged examples) land on the next docs publish.26.08.1stay on the older Live RAG examples until a later package cut. That is a release-train item, not this PR.Test plan
LiteLLMClient.__doc__no longer listsNVIDIA_API_KEYas an auto-read variableNVIDIA_NIM_API_KEYfornvidia_nimandos.environ/NVIDIA_API_KEYas the explicit forwardnemo_retriever/src/nemo_retriever/models/llm/clients/litellm.py