Skip to content

fix(ci): ensure Node.js version >=22 in workflows#1048

Open
learnwithdevopsengineer3682 wants to merge 9 commits intoNVIDIA:mainfrom
learnwithdevopsengineer3682:fix/ci-node-version
Open

fix(ci): ensure Node.js version >=22 in workflows#1048
learnwithdevopsengineer3682 wants to merge 9 commits intoNVIDIA:mainfrom
learnwithdevopsengineer3682:fix/ci-node-version

Conversation

@learnwithdevopsengineer3682
Copy link
Copy Markdown

@learnwithdevopsengineer3682 learnwithdevopsengineer3682 commented Mar 28, 2026

Summary

This PR ensures that the CI workflow uses a Node.js version compatible with the project requirement (>=22), as defined in CONTRIBUTING.md.

Currently, the workflow does not explicitly set a Node.js version, which may result in CI running with a lower default version. This can lead to installer failures and inconsistent runtime behavior.

Related Issue

Closes #<943>

Changes

  • Added Node.js setup step using actions/setup-node@v4
  • Ensured Node.js version >=22 is used across CI workflow jobs
  • Aligned CI environment with documented project requirements

Type of Change

  • Code change for a new feature, bug fix, or refactor.
  • Code change with doc updates.
  • Doc only. Prose changes without code sample modifications.
  • Doc only. Includes code sample changes.

Testing

  • npx prek run --all-files passes (or make check)
  • npm test passes.
  • make docs builds without warnings. (for doc-only changes)

Checklist

General

  • I have read and followed the contributing guide.
  • I have read and followed the style guide. (for doc-only changes)

Code Changes

  • Formatters applied — npx prek run --all-files
  • Tests added or updated for new or changed behavior.
  • No secrets, API keys, or credentials committed.
  • Doc pages updated for any user-facing behavior changes.

Notes

Happy to adjust this approach or integrate it differently into existing workflows if preferred.

Summary by CodeRabbit

  • Chores
    • CI for end-to-end tests updated to use Node.js 22 and enable npm dependency caching, improving test reliability and speed.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 28, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Added Node.js setup steps to two GitHub Actions workflow jobs (cloud-e2e and cloud-experimental-e2e) using actions/setup-node@v6 configured for Node.js version 22 with npm dependency caching enabled.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Configuration
\.github/workflows/nightly-e2e.yaml
Inserted actions/setup-node@v6 step (Node.js 22, cache: 'npm') immediately after actions/checkout@v6 in cloud-e2e and cloud-experimental-e2e jobs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 I hopped in the CI with a spring and a grin,
added Node twenty-two so builds could begin,
cached npm treasures snug in their nest,
two jobs now hum, doing their best,
— a little rabbit's gift for faster tests.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: adding Node.js version 22 setup to CI workflows to ensure consistent environment requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/nightly-e2e.yaml:
- Around line 42-46: Update the "Setup Node.js" steps in the cloud-e2e and
cloud-experimental-e2e jobs to use actions/setup-node@v6 (replace `@v4`) and add
the same cache configuration block used in other workflows (the cache:
node-modules/npm or the established cache inputs) so the step names "Setup
Node.js" match the other workflows; locate the two steps by the job names
cloud-e2e and cloud-experimental-e2e and the existing "Setup Node.js" action and
apply the version and cache changes there.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 48fec02d-3873-4945-bc26-dafd5d4ed693

📥 Commits

Reviewing files that changed from the base of the PR and between eb4ba8c and fc118a6.

📒 Files selected for processing (1)
  • .github/workflows/nightly-e2e.yaml

@wscurran wscurran added CI/CD Use this label to identify issues with NemoClaw CI/CD pipeline or GitHub Actions. fix labels Mar 30, 2026
@wscurran
Copy link
Copy Markdown
Contributor

✨ Thanks for submitting this fix with a detailed summary, it identifies a CI workflow issue and proposes a solution to ensure that the Node.js version is compatible with the project requirements, which could improve the reliability of the CI workflow.

@learnwithdevopsengineer3682
Copy link
Copy Markdown
Author

Thanks for the feedback!
I’ve resolved the merge conflicts and aligned the Node.js version with the latest upstream workflow.
CI workflows are pending approval happy to proceed once they are triggered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Use this label to identify issues with NemoClaw CI/CD pipeline or GitHub Actions. fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants