fix(scripts): enforce config integrity check in non-root mode by latenighthackathon · Pull Request #1071 · NVIDIA/NemoClaw

latenighthackathon · 2026-03-29T19:54:47Z

Summary

In non-root mode, verify_config_integrity() failure was logged as a warning but execution continued, allowing a tampered openclaw.json to be loaded. The root path already treats this as fatal. Now consistent: exit 1 on failure in both modes.

Related Issue

Closes #1013

Changes

Changed non-root integrity failure from warning to fatal exit 1
Message updated to match severity: '[SECURITY] ... refusing to start'
Root path behavior unchanged (already fatal via set -euo pipefail)

Type of Change

Code change for a new feature, bug fix, or refactor.
Code change with doc updates.
Doc only. Prose changes without code sample modifications.
Doc only. Includes code sample changes.

Testing

npx prek run --all-files passes (or equivalently make check).
npm test passes.
make docs builds without warnings. (for doc-only changes)

Checklist

General

I have read and followed the contributing guide.

Code Changes

Formatters applied.
No secrets, API keys, or credentials committed.

Summary by CodeRabbit

Security
- Configuration integrity verification is now enforced at startup. The application will immediately refuse to start if verification fails, preventing operation with potentially corrupted configuration.
Tests
- Added automated tests to validate startup behavior and ensure configuration verification is invoked and enforced in all execution paths.

coderabbitai · 2026-03-29T19:55:26Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ca979a36-7829-46a7-a36d-bd66f6deb26f

📥 Commits

Reviewing files that changed from the base of the PR and between 8921233 and 1ce22ed.

📒 Files selected for processing (1)

test/nemoclaw-start.test.js

📝 Walkthrough

Walkthrough

The non-root execution path in scripts/nemoclaw-start.sh now treats config integrity verification failures as fatal: instead of logging a warning and continuing, the script logs a [SECURITY] message and exits with status 1.

Changes

Cohort / File(s)	Summary
Startup Script `scripts/nemoclaw-start.sh`	Non-root path: `verify_config_integrity` failure is now handled as fatal — emits `[SECURITY]` message then `exit 1` instead of warning and continuing.
Tests `test/nemoclaw-start.test.js`	Added tests: assert non-root path exits with status 1 on integrity check failure and verify `verify_config_integrity` is invoked in both root and non-root paths (multiple occurrences).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 From my cozy burrow I peep and say,
When hashes falter, we will not play.
A warning silenced, the gateway halts,
Guards at the door, no stealthy faults. 🥕🔒

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix(scripts): enforce config integrity check in non-root mode' directly describes the main change: making config integrity checks fatal in non-root mode, which is the primary objective of the PR.
Linked Issues check	✅ Passed	The PR fully addresses issue `#1013` by making non-root config integrity check failures fatal (exit 1) with a [SECURITY] message, and adding tests to verify both non-root and root paths call verify_config_integrity.
Out of Scope Changes check	✅ Passed	All changes are in scope: the script fix implements the fatal check requirement, and test additions validate the fix. No unrelated code changes were introduced.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

🧹 Nitpick comments (1)

scripts/nemoclaw-start.sh (1)
326-329: Root path behavior remains correct and consistent.

The root path relies on set -euo pipefail to make verify_config_integrity fatal, which works correctly. Both execution paths now consistently refuse to start on integrity failures.

Operational note: Per the relevant code snippets, some callers (bin/lib/onboard.js, scripts/telegram-bridge.js, scripts/walkthrough.sh) may not properly propagate the exit code when invoking nemoclaw-start outside the ENTRYPOINT context (e.g., via SSH, tmux, or openshell sandbox create). While this script now correctly exits with status 1 on integrity failure, the callers may silently ignore it. Consider auditing those call sites to ensure security failures are surfaced to users.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@scripts/nemoclaw-start.sh` around lines 326 - 329, The script now correctly
exits with non-zero on verify_config_integrity failures, but some callers
(bin/lib/onboard.js, scripts/telegram-bridge.js, scripts/walkthrough.sh) may not
propagate that exit code; audit those call sites and ensure they detect and
forward the child process exit status (e.g., check spawn/exec return codes or
use synchronous/awaited execution and process.exit(retcode) when invoking
nemoclaw-start) so integrity failures are not silently ignored.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@scripts/nemoclaw-start.sh`:
- Around line 326-329: The script now correctly exits with non-zero on
verify_config_integrity failures, but some callers (bin/lib/onboard.js,
scripts/telegram-bridge.js, scripts/walkthrough.sh) may not propagate that exit
code; audit those call sites and ensure they detect and forward the child
process exit status (e.g., check spawn/exec return codes or use
synchronous/awaited execution and process.exit(retcode) when invoking
nemoclaw-start) so integrity failures are not silently ignored.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8b745840-0871-4fb6-a7ee-a98c7aaed0f3

📥 Commits

Reviewing files that changed from the base of the PR and between eb4ba8c and 0285fb0.

📒 Files selected for processing (1)

scripts/nemoclaw-start.sh

latenighthackathon · 2026-03-29T20:13:48Z

Caller audit (addressing CodeRabbit review suggestion)

Audited the three call sites that invoke nemoclaw-start outside the Docker ENTRYPOINT context:

bin/lib/onboard.js:1813 — passes nemoclaw-start as the command to openshell sandbox create. Exit status is checked at line 1825 (createResult.status !== 0) and surfaced to the user. ✅ Already propagates.
scripts/telegram-bridge.js:108 — invokes nemoclaw-start openclaw agent ... via SSH. The close event handler at line 121 captures the exit code, and line 144 surfaces non-zero exits with stderr output (which would include the [SECURITY] message). ✅ Already propagates.
scripts/walkthrough.sh:91 — runs nemoclaw-start inside an interactive tmux split via openshell sandbox connect. The exit code is visible to the operator in the terminal. ✅ Visible by design.

Conclusion: All callers already propagate or surface the exit code. No code changes needed.

In non-root mode, verify_config_integrity() failure was logged as a warning but execution continued, allowing a tampered openclaw.json to be loaded. The root path correctly treats this as fatal. Make the non-root path consistent: exit 1 on integrity failure so a modified config is never silently accepted regardless of the execution mode. Closes NVIDIA#1013

…nonroot

Verify that the non-root code path exits on verify_config_integrity failure and does not contain the old "proceeding anyway" fallback. Also verify both root and non-root paths call verify_config_integrity. Signed-off-by: latenighthackathon <latenighthackathon@users.noreply.github.com>

latenighthackathon · 2026-03-30T18:40:30Z

Added two regression tests in the latest commit verifying the non-root integrity exit and ensuring both code paths call verify_config_integrity.

Related: @Junior00619 also tackled this in #1032 — appreciate the parallel effort on this one. Their PR independently identified the same fix and included test coverage as well.

Junior00619 · 2026-03-30T18:43:14Z

Added two regression tests in the latest commit verifying the non-root integrity exit and ensuring both code paths call verify_config_integrity.

Related: @Junior00619 also tackled this in #1032 — appreciate the parallel effort on this one. Their PR independently identified the same fix and included test coverage as well.

Appreciate the tag! Lets continue building :))!

kjw3 · 2026-03-30T18:57:54Z

Review note: I compared #1071 and #1032 directly against current main. Both addressed issue #1013 correctly by making the non-root config-integrity check fatal in scripts/nemoclaw-start.sh and both added appropriate regression coverage in test/nemoclaw-start.test.js. The main difference was branch quality: #1032 had the cleaner history and slightly clearer tests, while #1071 carried substantial merge-noise. Since #1071 is now merged, the issue is resolved by this PR.

…#1071) * sec(scripts): enforce config integrity check in non-root mode In non-root mode, verify_config_integrity() failure was logged as a warning but execution continued, allowing a tampered openclaw.json to be loaded. The root path correctly treats this as fatal. Make the non-root path consistent: exit 1 on integrity failure so a modified config is never silently accepted regardless of the execution mode. Closes NVIDIA#1013 * test(scripts): add regression tests for non-root config integrity exit Verify that the non-root code path exits on verify_config_integrity failure and does not contain the old "proceeding anyway" fallback. Also verify both root and non-root paths call verify_config_integrity. Signed-off-by: latenighthackathon <latenighthackathon@users.noreply.github.com> --------- Signed-off-by: latenighthackathon <latenighthackathon@users.noreply.github.com> Co-authored-by: latenighthackathon <latenighthackathon@users.noreply.github.com> Co-authored-by: KJ <kejones@nvidia.com>

* sec(scripts): enforce config integrity check in non-root mode In non-root mode, verify_config_integrity() failure was logged as a warning but execution continued, allowing a tampered openclaw.json to be loaded. The root path correctly treats this as fatal. Make the non-root path consistent: exit 1 on integrity failure so a modified config is never silently accepted regardless of the execution mode. Closes #1013 * test(scripts): add regression tests for non-root config integrity exit Verify that the non-root code path exits on verify_config_integrity failure and does not contain the old "proceeding anyway" fallback. Also verify both root and non-root paths call verify_config_integrity. Signed-off-by: latenighthackathon <latenighthackathon@users.noreply.github.com> --------- Signed-off-by: latenighthackathon <latenighthackathon@users.noreply.github.com> Co-authored-by: latenighthackathon <latenighthackathon@users.noreply.github.com> Co-authored-by: KJ <kejones@nvidia.com>

…#1071) * sec(scripts): enforce config integrity check in non-root mode In non-root mode, verify_config_integrity() failure was logged as a warning but execution continued, allowing a tampered openclaw.json to be loaded. The root path correctly treats this as fatal. Make the non-root path consistent: exit 1 on integrity failure so a modified config is never silently accepted regardless of the execution mode. Closes NVIDIA#1013 * test(scripts): add regression tests for non-root config integrity exit Verify that the non-root code path exits on verify_config_integrity failure and does not contain the old "proceeding anyway" fallback. Also verify both root and non-root paths call verify_config_integrity. Signed-off-by: latenighthackathon <latenighthackathon@users.noreply.github.com> --------- Signed-off-by: latenighthackathon <latenighthackathon@users.noreply.github.com> Co-authored-by: latenighthackathon <latenighthackathon@users.noreply.github.com> Co-authored-by: KJ <kejones@nvidia.com>

coderabbitai Bot reviewed Mar 29, 2026

View reviewed changes

latenighthackathon changed the title ~~sec(scripts): enforce config integrity check in non-root mode~~ fix(scripts): enforce config integrity check in non-root mode Mar 29, 2026

latenighthackathon force-pushed the fix/config-integrity-nonroot branch from 0285fb0 to 8921233 Compare March 29, 2026 22:12

Merge remote-tracking branch 'origin/main' into fix/config-integrity-…

3872270

…nonroot

kjw3 self-assigned this Mar 30, 2026

kjw3 approved these changes Mar 30, 2026

View reviewed changes

kjw3 and others added 8 commits March 30, 2026 13:55

Merge branch 'main' into fix/config-integrity-nonroot

654b776

Merge branch 'main' into fix/config-integrity-nonroot

6b03291

Merge branch 'main' into fix/config-integrity-nonroot

f9999df

Merge branch 'main' into fix/config-integrity-nonroot

2179a98

Merge branch 'main' into fix/config-integrity-nonroot

0a000cf

Merge branch 'main' into fix/config-integrity-nonroot

dad691d

Merge branch 'main' into fix/config-integrity-nonroot

bf7d4b5

Merge branch 'main' into fix/config-integrity-nonroot

403bc6e

cv merged commit 5825739 into NVIDIA:main Mar 30, 2026
8 checks passed

kjw3 mentioned this pull request Mar 30, 2026

fix(scripts): make config integrity check fatal in non-root mode #1032

Closed

latenighthackathon deleted the fix/config-integrity-nonroot branch March 30, 2026 19:04

wscurran added the bug-fix PR fixes a bug or regression label Jun 8, 2026

Navigation Menu

Uh oh!

fix(scripts): enforce config integrity check in non-root mode - #1071

fix(scripts): enforce config integrity check in non-root mode#1071
cv merged 11 commits into
NVIDIA:mainfrom
latenighthackathon:fix/config-integrity-nonroot

latenighthackathon commented Mar 29, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Mar 29, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

coderabbitai Bot left a comment

Uh oh!

latenighthackathon commented Mar 29, 2026

Uh oh!

latenighthackathon commented Mar 30, 2026

Uh oh!

Junior00619 commented Mar 30, 2026

Uh oh!

Uh oh!

kjw3 commented Mar 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

latenighthackathon commented Mar 29, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related Issue

Changes

Type of Change

Testing

Checklist

General

Code Changes

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Mar 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

latenighthackathon commented Mar 29, 2026

Caller audit (addressing CodeRabbit review suggestion)

Uh oh!

latenighthackathon commented Mar 30, 2026

Uh oh!

Junior00619 commented Mar 30, 2026

Uh oh!

Uh oh!

kjw3 commented Mar 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

latenighthackathon commented Mar 29, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Mar 29, 2026 •

edited

Loading