c.parallel: enable dynamic policies in unique_by_key. #6087
+123
−143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
😬 CI Workflow Results🟥 Finished in 6h 28m: Pass: 98%/185 | Total: 3d 12h | Max: 4h 09m | Hits: 94%/190718See results here. |
NaderAlAwar
approved these changes
Oct 1, 2025
|
|
||
| operation_t op = make_operation( | ||
| "op", | ||
| "struct large_key_pair { int a; char c[100]; };\n" |
There was a problem hiding this comment.
Important: instead of deleting this, let us keep it but increase the size of the dtype. Use char c[500] here instead. The reason the build succeeds after your changes is that the selected policy uses a smaller block size with less items per thread, which allows us to use a type of this size without running out of shared memory.
VSmem is still not supported, if you search for VSMemPerBlock in unique_by_key.cu you can see we return 0.
This issue is tracked here #3790
NaderAlAwar
reviewed
Oct 1, 2025
| struct large_key_pair | ||
| { | ||
| int a; | ||
| char c[100]; |
There was a problem hiding this comment.
You will also want to update the size here
bernhardmgruber
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: the "big keys shouldn't compile" case started compiling because we now actually do the proper math, presumably that's fine? I'd like some confirmation on that one.
Resolves #4362
Checklist