Skip to content

Conversation

ericniebler
Copy link
Contributor

Description

closes #6078

recently cuda::std::complex got the tuple treatment. but __make_tuple_types was not updated to handle complex special, like it does for cuda::std::array. this PR fixes that.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Copy link
Contributor

copy-pr-bot bot commented Oct 1, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Progress in CCCL Oct 1, 2025
@ericniebler
Copy link
Contributor Author

/ok to test f05eb74

@ericniebler
Copy link
Contributor Author

/ok to test 8714a5f

This comment has been minimized.

@github-project-automation github-project-automation bot moved this from In Progress to In Review in CCCL Oct 2, 2025
@miscco
Copy link
Contributor

miscco commented Oct 2, 2025

/ok to test

@davebayer
Copy link
Contributor

Actually, I implemented P2819R2 back in #2882. We should backport these changes to 3.1 and 3.0.

@miscco
Copy link
Contributor

miscco commented Oct 2, 2025

/ok to test

@miscco
Copy link
Contributor

miscco commented Oct 2, 2025

/ok to test

@miscco miscco marked this pull request as ready for review October 2, 2025 09:00
@miscco miscco requested a review from a team as a code owner October 2, 2025 09:00
@miscco miscco requested a review from pciolkosz October 2, 2025 09:00
Copy link
Contributor

github-actions bot commented Oct 2, 2025

🥳 CI Workflow Results

🟩 Finished in 4h 46m: Pass: 100%/242 | Total: 10d 12h | Max: 4h 44m | Hits: 31%/304335

See results here.

@bernhardmgruber bernhardmgruber merged commit 7ed0f91 into NVIDIA:main Oct 2, 2025
254 of 255 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Oct 2, 2025
Copy link
Contributor

github-actions bot commented Oct 2, 2025

Backport failed for branch/3.0.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin branch/3.0.x
git worktree add -d .worktree/backport-6102-to-branch/3.0.x origin/branch/3.0.x
cd .worktree/backport-6102-to-branch/3.0.x
git switch --create backport-6102-to-branch/3.0.x
git cherry-pick -x 7ed0f91a4fb1dfb897fd7c0511e511c8d7dffc5e

@bernhardmgruber
Copy link
Contributor

  • microsoft's compiler is the bane of my existence

Love it. Kept it in the commit message 👍

Copy link
Contributor

github-actions bot commented Oct 2, 2025

Backport failed for branch/3.1.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin branch/3.1.x
git worktree add -d .worktree/backport-6102-to-branch/3.1.x origin/branch/3.1.x
cd .worktree/backport-6102-to-branch/3.1.x
git switch --create backport-6102-to-branch/3.1.x
git cherry-pick -x 7ed0f91a4fb1dfb897fd7c0511e511c8d7dffc5e

davebayer added a commit to davebayer/cccl that referenced this pull request Oct 2, 2025
davebayer pushed a commit to davebayer/cccl that referenced this pull request Oct 2, 2025
davebayer added a commit that referenced this pull request Oct 2, 2025
davebayer added a commit that referenced this pull request Oct 2, 2025
@ericniebler ericniebler deleted the fix-make-tuple-types-for-complex branch October 2, 2025 21:26
AyodeAwe pushed a commit to rapidsai/rapids-cmake that referenced this pull request Oct 7, 2025
## Description
<!-- Provide a standalone description of changes in this PR. -->

Backport bump of CCCL to 3.0.3 to include
NVIDIA/cccl#4796 and
NVIDIA/cccl#6102

<!-- Reference any issues closed by this PR with "closes #1234". -->
<!-- Note: The pull request title will be included in the CHANGELOG. -->

## Checklist
- [x] I am familiar with the [Contributing
Guidelines](https://github.com/rapidsai/rapids-cmake/blob/HEAD/CONTRIBUTING.md).
- [x] New or existing tests cover these changes.
- [x] The documentation is up to date with these changes.
- [x] The `cmake-format.json` is up to date with these changes.
- [ ] I have added new files under rapids-cmake/
   - [ ] I have added include guards (`include_guard(GLOBAL)`)
- [ ] I have added the associated docs/ rst file and update the api.rst


cc @manopapad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[BUG]: "Wrong number of template arguments" compilation failure with thrust::copy and cuda::std::complex<double>

4 participants