Add CMakeLists.txt as Build tools - #8
Merged
Merged
Conversation
akshaysubr
requested changes
Aug 27, 2025
akshaysubr
left a comment
akshaysubr
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. Tested it out in the 25.04 pytorch container and it works well. Looks like the CI is currently failing though. Can merge once that is fixed.
akshaysubr
self-requested a review
August 27, 2025 23:34
akshaysubr
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a
CMakeLists.txtfile to support building the library with CMake. It configures compilation for both the C++ and the Python interface, making it easier to manage dependencies, and specify build targets.