fix(io): correct the misspelled compound resize warning identifier - #882
Open
ehennestad wants to merge 1 commit into
Open
fix(io): correct the misspelled compound resize warning identifier#882ehennestad wants to merge 1 commit into
ehennestad wants to merge 1 commit into
Conversation
ehennestad
marked this pull request as ready for review
August 27, 2026 09:57
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #882 +/- ##
=======================================
Coverage 95.27% 95.27%
=======================================
Files 234 234
Lines 8311 8311
=======================================
Hits 7918 7918
Misses 393 393 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ehennestad
force-pushed
the
fix-write-compound-warning-id
branch
from
August 27, 2026 14:53
58e3345 to
18486dd
Compare
ehennestad
enabled auto-merge
August 27, 2026 16:06
The warning raised when a continuous compound dataset cannot be resized used the identifier NWB:WriteCompund:ContinuousCompoundResize, spelling the function name without its second o. Every other identifier in the write path spells it correctly, and code selecting this warning by id has to reproduce the typo to match it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ehennestad
force-pushed
the
fix-write-compound-warning-id
branch
from
August 31, 2026 10:43
18486dd to
b76f09c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Claude insisted on fixing a typo in a warning ID :
Compund->CompoundWhat changed
NWB:WriteCompound:ContinuousCompoundResize.This is a behaviour change for code that selects the warning by its old, misspelled identifier. The warning text, and when it is raised, are unchanged. The identifier is the only thing that moves, and MatNWB does not treat warning identifiers as a stable interface elsewhere.
How to test
runtests('tests.unit.io.WriteTest')Checklist
fix #XXwhereXXis the issue number?🤖 Generated with Claude Code