Generalize validation - #1494
Closed
CodyCBakerPhD wants to merge 4 commits into
Closed
CodyCBakerPhD wants to merge 4 commits into
CodyCBakerPhD wants to merge 4 commits into
Conversation
Contributor
|
Related to #1432. @CodyCBakerPhD can you adjust this PR to branch off of dev? I have some thoughts on the modularize PR #1493. I'd like to get this PR sooner. |
Collaborator
Author
|
Replaced by #1511 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1431
Motivation
WIP synchronizing the behavior of the CLI
pynwb.validatefunction with the library-imported one, namely for the purposes of validating against cached namespaces (but also just to have identical behavior between library and CLI use cases).How to test the behavior?
Need to...
[ ] - Thoroughly test that the CLI usage behaves as it used to
[ ] - The cached namespace feature is indeed available to the new library method as well
[ ] - Ensure there is no break in back-combability when using the previous methods
Checklist
flake8from the source directory.enh/getcachednamespaces