Skip to content

Conversation

rly
Copy link
Contributor

@rly rly commented Jun 11, 2025

Motivation

Fix #2096

How to test the behavior?

Create extension that defines a DynamicTableRegion column. Use get_class to get the class, and use the target_tables keyword argument. See rly/ndx-optogenetics#6

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff check . && codespell from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

Copy link

codecov bot commented Jun 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.19%. Comparing base (b0973cc) to head (27244f1).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2097   +/-   ##
=======================================
  Coverage   95.19%   95.19%           
=======================================
  Files          28       28           
  Lines        2851     2851           
  Branches      736      736           
=======================================
  Hits         2714     2714           
  Misses         83       83           
  Partials       54       54           
Flag Coverage Δ
integration 74.04% <100.00%> (ø)
unit 85.16% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stephprince stephprince marked this pull request as ready for review October 6, 2025 17:09
@stephprince
Copy link
Contributor

@rly added a test and the target_tables arg to a few tables that I think were added since this PR had been created if you want to review

@rly rly enabled auto-merge (squash) October 6, 2025 17:27
@rly
Copy link
Contributor Author

rly commented Oct 6, 2025

Thank you @stephprince . This looks great to me. Please approve.

@rly rly merged commit 6ff7e44 into dev Oct 6, 2025
26 checks passed
@rly rly deleted the target_tables branch October 6, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Expose "target_tables" constructor argument for DynamicTable

2 participants