Move runPostBuildHook out of DerivationBuilder
#13802
Open
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is suppposed to be "post build" not "during the build" after all. Its location now matches that for the hook case (see elsewhere in `DerivationdBuildingGoal`). It was in a try-catch before, and now it isn't, but I believe that it is impossible for it to throw `BuildError`, which is sufficient for this code motion to be correct.
Ericson2314
commented
Aug 20, 2025
Comment on lines
509
to
511
| /* Delete unused redirected outputs (when doing hash rewriting). */ | ||
| for (auto & i : redirectedOutputs) | ||
| deletePath(store.Store::toRealPath(i.second)); |
There was a problem hiding this comment.
This means the post build hook can't do anything with these paths, but I think that's good. (And it would probably have hard time finding them anyways.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It is supposed to be "post build" not "during the build" after all. Its location now matches that for the hook case (see elsewhere in
DerivationdBuildingGoal).It was in a try-catch before, and now it isn't, but I believe that it is impossible for it to throw
BuildError, which is sufficient for this code motion to be correct.Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.