add Dell Pro 14 PA14250

README.md

@@ -160,6 +160,7 @@ See code for all available configurations.
 | [Dell Precision 5490](dell/precision/5490)                                        | `<nixos-hardware/dell/precision/5490>`                  | `dell-precision-5490`              |
 | [Dell Precision 5530](dell/precision/5530)                                        | `<nixos-hardware/dell/precision/5530>`                  | `dell-precision-5530`              |
 | [Dell Precision 7520](dell/precision/7520)                                        | `<nixos-hardware/dell/precision/7520>`                  | `dell-precision-7520`              |
+| [Dell Pro 14 PA14250](dell/dell-pro/PA14250)                                      | `<nixos-hardware/dell/dell-pro/PA14250>`                | `dell-pro-14-PA14250`              |
 | [Dell XPS 13 7390](dell/xps/13-7390)                                              | `<nixos-hardware/dell/xps/13-7390>`                     | `dell-xps-13-7390`                 |
 | [Dell XPS 13 9300](dell/xps/13-9300)                                              | `<nixos-hardware/dell/xps/13-9300>`                     | `dell-xps-13-9300`                 |
 | [Dell XPS 13 9310](dell/xps/13-9310)                                              | `<nixos-hardware/dell/xps/13-9310>`                     | `dell-xps-13-9310`                 |

dell/dell-pro/PA14250/default.nix

@@ -0,0 +1,60 @@
+{ lib, ... }:
+
+# Xe module fails to load on 6.12.x starting 6.12.35
+# tested to work on 6.13.4 or newer
+#
+# Bisect points at d42b44736ea29fa6d0c3cb9c75569314134b7732 but
+# 6.13 series 30d105577a3319094f8ae5ff1ceea670f1931487 looks identical
+# so it has to be not just that commit but its interactions with 6.12
+# driver version
+#
+# https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/5373
+let
+  brokenXeModule = version: lib.versionAtLeast version "6.12.35" && lib.versionOlder version "6.13.4";
+in
+{
+  imports = [
+    ../../../common/cpu/intel/lunar-lake
+    ../../../common/pc/laptop
+    ../../../common/pc/ssd
+  ];
+
+  hardware.intelgpu.driver = "xe";
+
+  boot = lib.mkMerge [
+    {
+      # use xe graphics module, i915 doesn't seem to work well
+      # just selecting xe seems to be not enough
+      blacklistedKernelModules = [ "i915" ];
+
+      kernelParams = [
+        # makes external display more stable
+        "xe.psr_safest_params=1"
+        # extra debug logs just in case something breaks
+        "xe.verbose_state_checks=true"
+      ];
+    }
+
+    # we can't inspect config.boot.kernelPackages.kernel.version to override kernelPackages as it's create a loop
+    # instead let's auto-apply latest kernel if linux_default is broken
+    #
+    # TODO: this may unnecessarily bump kernel to latest if say 6.13 is manually selected in configuration
+    #       maybe we need extra parameter to this module? Though should still already be possible to overrule module kernel selection.
+    #       Looking at linux_default version is also less restrictive than always setting latest,
+    #       once 6.12 is fixed we can update brokenXeModule expression and only do override on old nixpkgs versions that haven't yet
+    #       upgraded to a fixed kernel
+    (lib.mkIf (brokenXeModule pkgs.linuxKernel.packageAliases.linux_default.kernel.version) {
+      kernelPackages = pkgs.linuxPackages_latest;
+    })
+  ];
+
+  assertions = lib.optionals (config.hardware.intelgpu.driver == "xe") [
+    {
+      assertion = !(brokenXeModule config.boot.kernelPackages.kernel.version);
+      message = "xe driver would fail with 'probe with driver xe failed with error -110'";
+    }
+  ];
+
+  # Recommended in NixOS/nixos-hardware#127
+  services.thermald.enable = lib.mkDefault true;
+}

flake.nix

@@ -93,6 +93,7 @@
           dell-precision-5530 = import ./dell/precision/5530;
           dell-precision-5560 = import ./dell/precision/5560;
           dell-precision-7520 = import ./dell/precision/7520;
+          dell-pro-14-PA14250 = import ./dell/dell-pro/PA14250;
           dell-xps-13-7390 = import ./dell/xps/13-7390;
           dell-xps-13-9300 = import ./dell/xps/13-9300;
           dell-xps-13-9310 = import ./dell/xps/13-9310;