ncurses: 6.2 -> 6.3

[trofi]

The biggest nixpkgs-specific change is addition of printf()-style
attribute annotations for many ncurses APIs. -Werror=format-security
now flags parameter inconsistencies and fails the build.

The fixes are usually one-liners like adding "%s" format string for
non-literals or just using hardeningDisable [ "format" ]; for software
where backporting or fixing is not practical.

Almost all of build failures are already sorted in nixpkgs/master (~60 changes).

[trofi]

Still known broken packages:

• _2048-in-terminal: _2048-in-terminal: 2017-11-29 -> 2021-09-12 #146878
• liboping: liboping: pull pending upstream inclusion fix for ncurses-6.3 #147725
• noice: noice: fix build against ncurses-6.3 #147727
• samtools: samtools: pull upstream fix for ncurses-6.3 #147499
• libviper: libviper: fix build against ncurses-6.3 #147728
• vwm: vwm: fix build against ncurses-6.3 #147729
• gptfdisk: gptfdisk: fix build against upcoming ncurses-6.3 #147778
• spdk: spdk: upstream fix for ncurses-6.3 #148083
• wiimms-iso-tools: wiimms-iso-tools: pull pending upstream inclusion fix for ncurses-6.3 #146600
• nfstrace: nfstrace: pull pending upstream inclusion fix for ncurses-6.3 #146469
• musikcube: musikcube: pull pending upstream inclusion fix for ncurses-6.3 #146363

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/uncoming-ncurses-6-2-6-3-update/16169/1

[Mic92]

I merged all out-standing PRs linked here.

[trofi]

Thank you!

I asked a hydra run against this PR: https://hydra.nixos.org/jobset/nixpkgs/pr-146685 . Current run is against somewhat older staging state.

My immediate plan is:

1. [done] Rebase against recent master run : https://hydra.nixos.org/eval/1727143?compare=1727080&full=0
2. [done] Fix failures against master
3. [done] Promote this PR from draft.

[trofi]

New failures found by first hydra run (still ongoing, to be extended):

• postgresqlPackages.pg_auto_failover: postgresqlPackages.pg_auto_failover: upstream fix for ncurses-6.3 #148621
• rogue: will drop -DNCURSES_INTERNALS=1 workaround along with ncurses bump
• wyrd: will drop -DNCURSES_INTERNALS=1 workaround along with ncurses bump
• squishyball: will drop -DNCURSES_INTERNALS=1 workaround along with ncurses bump
• haskellPackages.ncurses: haskellPackages.ncurses: mark as broken #148629
• liboping: liboping: fix format arguments for printf() #148623
• linuxPackages.sysdig: sysdig: fix pending upstream inclusion for ncurses-6.3 #148626
• tcptrack: tcptrack: fix build on ncurses-6.3 #148726
• pamix: pamix: fix pending upstream inclusion for ncurses-6.3 #148945
• tlf: tlf: upstream fix for ncurses-6.3 #148964

[trofi]

Rebasing against https://hydra.nixos.org/eval/1729230 5c96dfa.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/uncoming-ncurses-6-2-6-3-update/16169/2

[trofi]

All known failures are sorted out. Ready for staging.

The one exception is haskellPackages.ncurses: #148629. We'll give upstream a few days before marking it and it's reverse depends broken.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/675

[vcunat]

• squishyball now won't build, probably due to this update: https://hydra.nixos.org/build/164574558

Maybe you've seen a similar error already? I see you dropped a flag for this build, but reintroducing it doesn't fix this error.

[trofi]

I wonder how I missed it. The other two (rogue and wyrd do build now). The build breakage:

mincurses.c:345:20: error: 'TERMINAL' {aka 'struct term'} has no member named 'Nttyb'
  345 |     term = cur_term->Nttyb;
      |                    ^~

is the result of mirror/ncurses@493e2f7 move internals of TERMINAL structure to new header term.priv.h. which moves TTY Nttyb; field out of public headers completely. I'll try to find an API substitute for it.

[trofi]

Filed upstream issue as https://gitlab.xiph.org/xiph/squishyball/-/issues/1

[trofi]

Proposed fix for nixpkgs as #156781