Skip to content

python313Packages.uvloop: patch for broken tests#398352

Merged
wolfgangwalther merged 1 commit intoNixOS:staging-nextfrom
FliegendeWurst:uvloop-py313
Apr 26, 2025
Merged

python313Packages.uvloop: patch for broken tests#398352
wolfgangwalther merged 1 commit intoNixOS:staging-nextfrom
FliegendeWurst:uvloop-py313

Conversation

@FliegendeWurst
Copy link
Copy Markdown
Member

@FliegendeWurst FliegendeWurst commented Apr 13, 2025 •
edited
Loading

Probably broke in a Python patch update? (full log)
The upstream report used Python 3.14 MagicStack/uvloop#637 (comment)

MagicStack/uvloop#662
MagicStack/uvloop#663

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Apr 13, 2025
@wolfgangwalther
Copy link
Copy Markdown
Contributor

wolfgangwalther commented Apr 26, 2025

I didn't test, but maybe one of the following two will already fix it for 3.13?

@wolfgangwalther
Copy link
Copy Markdown
Contributor

wolfgangwalther commented Apr 26, 2025

Could possibly go into staging-next.

@FliegendeWurst
Copy link
Copy Markdown
Member Author

FliegendeWurst commented Apr 26, 2025

It would go in staging-next now, yes. I'll check out the patches you linked.

@FliegendeWurst FliegendeWurst changed the base branch from staging to staging-next April 26, 2025 12:16
@FliegendeWurst FliegendeWurst changed the title python313Packages.uvloop: disable broken test python313Packages.uvloop: patch for broken tests Apr 26, 2025
@FliegendeWurst
Copy link
Copy Markdown
Member Author

FliegendeWurst commented Apr 26, 2025

Updated to use the linked patches, works

wolfgangwalther
wolfgangwalther approved these changes Apr 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not build, but LGTM.

@github-project-automation github-project-automation bot moved this from In progress to Reviewer approved in Python batch upgrade Apr 26, 2025
@LordGrimmauld
Copy link
Copy Markdown
Contributor

LordGrimmauld commented Apr 26, 2025

Building rn

@LordGrimmauld
Copy link
Copy Markdown
Contributor

LordGrimmauld commented Apr 26, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 398352 --package python312Packages.uvloop --package python313Packages.uvloop

x86_64-linux

✅ 4 packages built:
  • python312Packages.uvloop
  • python312Packages.uvloop.dist (python312Packages.uvloop.dist.dist)
  • python313Packages.uvloop
  • python313Packages.uvloop.dist (python313Packages.uvloop.dist.dist)

@LordGrimmauld
Copy link
Copy Markdown
Contributor

LordGrimmauld commented Apr 26, 2025

Python 3.14 is broken because greenlet(dependency) is broken, so can't test that. But hydra doesn't build that, and either way this isn't the topic here - should be fine!

@wolfgangwalther wolfgangwalther merged commit b95451b into NixOS:staging-next Apr 26, 2025
35 of 39 checks passed
@github-project-automation github-project-automation bot moved this from Reviewer approved to Done in Python batch upgrade Apr 26, 2025
@LordGrimmauld LordGrimmauld mentioned this pull request Apr 27, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfgangwalther wolfgangwalther wolfgangwalther approved these changes

@LordGrimmauld LordGrimmauld LordGrimmauld approved these changes

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

Python batch upgrade
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FliegendeWurst @wolfgangwalther @LordGrimmauld