Skip to content

Call BzDecoder::flush on finish #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Call BzDecoder::flush on finish #336

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
527b870
Call BzDecoder::flush on finish
NobodyXu Mar 21, 2025
c0b98d5
Merge branch 'main' into NobodyXu-patch-1
robjtede Jun 12, 2025
df9907a
Fix src/codec/bzip2/decoder.rs
NobodyXu Jun 12, 2025
6790fd9
Fix src/codec/bzip2/decoder.rs
NobodyXu Jun 12, 2025
6f592e1
Fix src/codec/bzip2/decoder.rs
NobodyXu Jun 12, 2025
7336170
Fix src/codec/bzip2/decoder.rs
NobodyXu Jun 12, 2025
51659d9
Fix status matching
NobodyXu Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/codec/bzip2/decoder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,19 @@
}

fn finish(
&mut self,

Check warning on line 99 in src/codec/bzip2/decoder.rs

View workflow job for this annotation

GitHub Actions / cargo fmt --check 

Diff in /home/runner/work/async-compression/async-compression/src/codec/bzip2/decoder.rs
_output: &mut PartialBuffer<impl AsRef<[u8]> + AsMut<[u8]>>,
output: &mut PartialBuffer<impl AsRef<[u8]> + AsMut<[u8]>>,
) -> io::Result<bool> {
Ok(true)
match self.decode(
&mut PartialBuffer::new(&[][..]),
output,
)? {
Status::Ok
| Status::FlushOk
| Status::RunOk
| Status::FinishOk => Ok(false),
Status::StreamEnd => Ok(true),
Status::MemNeeded => Err(io::ErrorKind::OutOfMemory.into()),
}
}
}
Loading