PD-6181 Note other verified emails on the password reset confirmation - #2910
Open
cryptalith wants to merge 1 commit into
Open
PD-6181 Note other verified emails on the password reset confirmation#2910cryptalith wants to merge 1 commit into
cryptalith wants to merge 1 commit into
Conversation
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the password recovery confirmation copy for PD-6181, now that the backend sends the reset link to every verified address on the account.
We have sent a recovery email to <email>→We have sent a recovery email to <email> and any other verified email addresses on your accountWhat changed
@@recovery.andAnyOtherVerifiedEmails, appended as a sibling fragment.@@recovery.weHaveSentis left byte-identical so its translations in all ~19 locales survive; the new fragment simply arrives untranslated and fills in on the next Transifex pull. Editing the existing source in place would have put every locale at risk.recoveryType === 'password'via a newisPasswordResetgetter. The confirmation block is shared with the "remind me my ORCID iD" flow, which posts to/forgot-id.jsonand still emails a single address — showing the fan-out wording there would be a lie. The getter is safe to read at confirmation time:recoveryTypeis initialised to'password'and its radio group lives inside the@if (!submitted)branch, so it cannot change once submitted.> <b>idiom. The component does not setpreserveWhitespaces, so a leading space inside the span would have been trimmed out of the extracted source.Translation artifacts
yarn build:i18ntouched onlymessages.xlfand the three auto-stamped pseudo-locales (xx,lr,rl) — no real locale file is in the diff, which is the check that the deprecated properties path did not run.Testing
ng test ng-orcid: 757 passing, no failures.Three new specs on a component that previously had only
should create: the sentence renders on the password path, is absent on the forgot-iD path, and the submitted email still renders in both modes. The positive spec was confirmed to fail without the template change.Also checked in a browser against a dev server, by driving the component directly (
window.ng.getComponent(el)to setrecoveryTypeand flipsubmitted) rather than submitting the form — there was no backend behind the local proxy, so this exercises the rendered template and theisPasswordResetgate, not the real submit path. It confirms the markup keeps a non-breaking space on both sides of the bold email, and that the iD-recovery path shows the original sentence unchanged:Deploy order
Ships after ORCID/ORCID-Source#7651. With the backend not yet live the page would promise a fan-out that is not happening; the reverse order is harmless.