Skip to content

Conversation

berezovskyi
Copy link
Member

No description provided.

@berezovskyi berezovskyi requested a review from Copilot August 20, 2025 13:15
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the lyo-client-samples project from using deprecated client-specific OSLC resource classes to the standardized oslc-domains library. The migration involves updating imports, method calls, and data structures to align with the new API.

Key changes include:

  • Replacing legacy org.eclipse.lyo.client.oslc.resources.* imports with org.eclipse.lyo.oslc.domains.* equivalents
  • Updating constants from OSLCConstants and resource-specific constants to domain-specific vocabulary constants
  • Converting array-based properties to Set-based collections with Link wrappers
  • Fixing method name changes and parameter types

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
pom.xml Updates dependency from legacy oslc-java-client-resources to oslc-domains 7.0.0.Alpha3
IAutomationRequestHandler.java Updates imports to use oslc-domains automation classes
ETMAutomationSample.java Comprehensive migration including method calls, constants, and data structure changes
AutomationRequestCanceledException.java Updates AutomationRequest import to oslc-domains
AutomationAdapter.java Migrates automation classes and adapts to new API patterns with Set/Link structures
RMSample.java Updates requirements management imports and constants, fixes duplicate title assignment
EWMSample.java Migrates change management classes and updates to use specific Task/Defect types
ETMSample.java Updates quality management imports and constants
ERMSample.java Comprehensive requirements management migration with extensive constant and method updates
CMSample.java Updates change management imports and fixes duplicate title assignment

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
@berezovskyi
Copy link
Member Author

berezovskyi commented Aug 20, 2025

@jadelkhoury this is the PR where I hit eclipse-lyo/lyo#783

I thought it was long overdue to migrate the samples from the legacy POCOs under https://github.com/eclipse-lyo/lyo/tree/master/client/oslc-java-client-resources

The PR runs successfully against Jazz.net w/o GCM, as before. Eliminating JazzChangeRequest would be desirable in the future.

Other things to fix:

  • get other samples in addition to EWM and ERM running
  • fix the typo in NAMSPACE in a nice way (old one made Obsolete and the new one introduced)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant