Modify scripts to pass dir paths as arguments #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve modified a few points in the scripts, mainly related to path handling. Currently, the scripts are running in a container. https://github.com/OpenHistoricalMap/ohm-deploy/tree/ohmexpress/images/ohmx-adiff-builder.
I created a bash script https://github.com/OpenHistoricalMap/ohm-deploy/blob/ohmexpress/images/ohmx-adiff-builder/start.sh where I centralize all the required directories, and from there I call the update.sh and process.sh scripts as well and run every minute.
In addition, I’ve added an INITIAL_SEQNUM argument to update.sh, which allows starting from a specific sequence number. This is needed because when I create my OSMX database for OHM, it initially doesn’t have a sequence set, so it’s necessary to define an initial sequence — usually a few hours before the planet dump was created. that works fine.
Perhaps these changes won’t be adopted, or maybe they could be useful in the future when we can add a Docker container to run the scripts more automatically.