Adds a TODO about gke-cloud-auth-plugin #57
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a comment to the Ubuntu Dockerfile to ensure that future maintainers will add the `gke-cloud-auth-plugin` if needed
Add a comment to the Ubuntu Dockerfile to ensure that future maintainers will add the `gke-cloud-auth-plugin` if needed
Author
|
I do not intend for us to tag or release a new version of WorkerTools based on this PR, it can just sit in |
ghost
approved these changes
Nov 30, 2022
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
LGTM, if we don't push a new tag then the release pipeline won't be triggered, so it is safe to just add this comment 👍
|
This pull request has been linked to Shortcut Story #6271: Update Kubernetes integration to support plugin-based architecture for vendor auth. |
|
Just an FYI - I found adding the See OctopusDeployLabs/k8s-workertools#6 for more details. If there is a more elegant way, I'd love to know it 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a no-op, it just adds a TODO comment for the future, if we bump
kubectl.[sc-6271]