Fix/wrong target type after renaming in csolution yaml file

[arneschmid]

Fixes stale Target Types remaining in UI after renamed in csolution.yml
This forces a reload of the yml file in the UI if a change on the file was detected, loosing local edits. Parallel editing of file and UI is currently not suppoerted.

Fixes

• Changing Target-Type creates issues in: Manage Solution View #29

Changes

• Fixes Manage Solution state consistency after external file changes and target renames.
• Adds external change detection for csolution/cmsis files
• Reloads solution data when on-disk updates are detected, and ensures the active target type always maps to a valid target before sending UI context.
• Updates load-state handling for activation transitions and adds focused unit tests and factory updates to cover the new behavior.

Screenshots

Checklist

• 🤖 This change is covered by unit tests (if applicable).
• 🤹 Manual testing has been performed (if necessary).
• 🛡️ Security impacts have been considered (if relevant).
• 📖 Documentation updates are complete (if required).
• 🧠 Third-party dependencies and TPIP updated (if required).

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

[qltysh]

Coverage Impact

⬆️ Merging this pull request will increase total coverage on main by 0.07%.

Modified Files with Diff Coverage (4)

Rating	File	% Diff	Uncovered Line #s
	src/generic/text-file.ts	100.0%
	src/generic/text-file.factory.ts	100.0%
	src/views/manage-solution/manage-solution-controller.ts	92.9%	199, 547
	src/views/manage-solution/manage-solution-webview-main.ts	85.0%	106, 116-117
	Total	92.8%

🤖 Increase coverage with AI coding...

In the `fix/wrong-target-type-after-renaming-in-csolution-yaml-file` branch, add test coverage for this new code:

- `src/views/manage-solution/manage-solution-controller.ts` -- Lines 199 and 547
- `src/views/manage-solution/manage-solution-webview-main.ts` -- Lines 106 and 116-117

🚦 See full report on Qlty Cloud »

🛟 Help

• Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

• Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

• File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

  • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

[Copilot]

Pull request overview

Fixes Manage Solution UI state becoming stale after external edits (e.g., renamed target-types in *.csolution.yml) by detecting on-disk changes, reloading solution state, and validating/correcting the active target type before publishing context to the webview.

Changes:

• Detect external modifications of csolution/cmsis.json via file stamps and reload solution data when needed.
• Ensure the active target type always resolves to a valid target after reloads/renames.
• Update load-state handling and add/adjust unit tests and factories.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/views/manage-solution/manage-solution-webview-main.ts	Reload/validate flow on solution load-state transitions; adds external-change-triggered reloads.
src/views/manage-solution/manage-solution-webview-main.test.ts	Adds coverage for external-change reload ordering; adjusts async timing in existing load-state tests.
src/views/manage-solution/manage-solution-controller.ts	Adds external-change detection and active target type correction logic; improves selection fallback.
src/solutions/solution-manager.factories.ts	Updates factories for the new activated load-state field.
src/generic/text-file.ts	Adds reusable external on-disk change detection to TextFile/ITextFile via mtime/size stamps.
src/generic/text-file.test.ts	Adds tests for external change detection behavior.
src/generic/text-file.factory.ts	Extends ITextFile test factory with new external-change methods.

---

You can also share your feedback on Copilot code review. Take the survey.