Skip to content

Feature/debug adapter file selection improvements#60

Open
arneschmid wants to merge 8 commits intomainfrom
feature/debug-adapter-file-selection-improvements
Open

Feature/debug adapter file selection improvements#60
arneschmid wants to merge 8 commits intomainfrom
feature/debug-adapter-file-selection-improvements

Conversation

@arneschmid
Copy link
Collaborator

Improve debug adapter file selection and file-opening usability in the Manage Solution view.

Fixes

Changes

  • Added a dedicated open-file icon action next to the Browse button so users can quickly open the currently entered file path.
  • Updated the file input action layout to keep controls aligned on one line and adjusted styling for better button sizing.
  • Fixed path handling so file operations resolve relative paths against the active solution directory before opening files or pre-populating the file dialog.
  • Enhanced the codicon component to support both custom CMSIS icons and standard VS Code codicons, while also forwarding native span attributes like click handlers and accessibility props.

Screenshots

image

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@github-actions
Copy link

github-actions bot commented Mar 13, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@qltysh
Copy link

qltysh bot commented Mar 16, 2026

Qlty

Coverage Impact

⬇️ Merging this pull request will decrease total coverage on main by 0.01%.

Modified Files with Diff Coverage (4)

RatingFile% DiffUncovered Line #s
Coverage rating: C Coverage rating: C
src/views/manage-solution/view/components/manage-solution.tsx75.0%461
Coverage rating: F Coverage rating: F
src/views/manage-solution/manage-solution-custom-editor.ts0.0%122
Coverage rating: A Coverage rating: A
src/views/common/components/cmsis-codicon.tsx100.0%
Coverage rating: C Coverage rating: C
src/views/manage-solution/manage-solution-webview-main.ts90.0%208
Total83.3%
🤖 Increase coverage with AI coding...

In the `feature/debug-adapter-file-selection-improvements` branch, add test coverage for this new code:

- `src/views/manage-solution/manage-solution-custom-editor.ts` -- Line 122
- `src/views/manage-solution/manage-solution-webview-main.ts` -- Line 208
- `src/views/manage-solution/view/components/manage-solution.tsx` -- Line 461

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves file-selection UX in the Manage Solution webview by adding a quick “open current path” action, refining layout/styling, and adjusting how file paths are handled when opening dialogs and rendering icons.

Changes:

  • Add an icon action next to “Browse” in Manage Solution to open the currently entered file path.
  • Resolve defaultUri for file dialogs against the active solution directory.
  • Extend CmsisCodicon to support both custom CMSIS icons and standard VS Code codicons (with passthrough span props).

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/views/manage-solution/view/components/manage-solution.tsx Adds the open-file icon button and updates the file-input addon layout.
src/views/manage-solution/view/components/manage-solution.css Tweaks button sizing and adds styling for the new icon button.
src/views/manage-solution/manage-solution-webview-main.ts Introduces relative-to-solution path resolution for dialog defaults; refactors open-file handling.
src/views/manage-solution/manage-solution-webview-main.test.ts Updates/extends tests around file opening and file dialog behaviors.
src/views/manage-solution/manage-solution-webview-main.factories.ts Adds factory wiring for an external file opener dependency.
src/views/manage-solution/manage-solution-custom-editor.ts Threads the external file opener into the Manage Solution webview main.
src/views/common/components/cmsis-codicon.tsx Enhances codicon component to support both custom glyphs and VS Code codicons and forwards span props.
src/desktop/extension.ts Passes the external file opener into the Manage Solution custom editor provider.

You can also share your feedback on Copilot code review. Take the survey.

@arneschmid arneschmid marked this pull request as ready for review March 16, 2026 08:57
@arneschmid arneschmid requested a review from edriouk March 16, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants