Feature/debug adapter file selection improvements#60
Feature/debug adapter file selection improvements#60arneschmid wants to merge 8 commits intomainfrom
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
…uestId in SELECT_FILE messages
|
Coverage Impact ⬇️ Merging this pull request will decrease total coverage on Modified Files with Diff Coverage (4)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
There was a problem hiding this comment.
Pull request overview
This PR improves file-selection UX in the Manage Solution webview by adding a quick “open current path” action, refining layout/styling, and adjusting how file paths are handled when opening dialogs and rendering icons.
Changes:
- Add an icon action next to “Browse” in Manage Solution to open the currently entered file path.
- Resolve
defaultUrifor file dialogs against the active solution directory. - Extend
CmsisCodiconto support both custom CMSIS icons and standard VS Code codicons (with passthrough span props).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/views/manage-solution/view/components/manage-solution.tsx | Adds the open-file icon button and updates the file-input addon layout. |
| src/views/manage-solution/view/components/manage-solution.css | Tweaks button sizing and adds styling for the new icon button. |
| src/views/manage-solution/manage-solution-webview-main.ts | Introduces relative-to-solution path resolution for dialog defaults; refactors open-file handling. |
| src/views/manage-solution/manage-solution-webview-main.test.ts | Updates/extends tests around file opening and file dialog behaviors. |
| src/views/manage-solution/manage-solution-webview-main.factories.ts | Adds factory wiring for an external file opener dependency. |
| src/views/manage-solution/manage-solution-custom-editor.ts | Threads the external file opener into the Manage Solution webview main. |
| src/views/common/components/cmsis-codicon.tsx | Enhances codicon component to support both custom glyphs and VS Code codicons and forwards span props. |
| src/desktop/extension.ts | Passes the external file opener into the Manage Solution custom editor provider. |
You can also share your feedback on Copilot code review. Take the survey.

Improve debug adapter file selection and file-opening usability in the Manage Solution view.
Fixes
Changes
Screenshots
Checklist