Skip to content

feat: support auto setting correct GAMEID for the application - #358

Draft
R1kaB3rN wants to merge 2 commits into
Open-Wine-Components:mainfrom
R1kaB3rN:auto-gameid
Draft

feat: support auto setting correct GAMEID for the application#358
R1kaB3rN wants to merge 2 commits into
Open-Wine-Components:mainfrom
R1kaB3rN:auto-gameid

Conversation

@R1kaB3rN

Copy link
Copy Markdown
Member

Based on some internal discussion, this pull request adds support for automatically setting the correct GAMEID for the application. This avoids the need of clients trying to figure out if there's a fix for the running game in their internal umu implementation or potentially getting it wrong. Instead, the client can simply delegate that work to umu-launcher. As a result, the umu-database will be fully and correctly leveraged, and clients can focus on improving their UX.

This feature can be enabled by passing 'none' to GAMEID and setting STORE to a valid store. For example:

GAMEID=none STORE=gog umu-run Games/umu/Flowers - Le Volume Sur Automne/FLOWERS.exe

Note: Currently this implementation matches by title name which is typically found in the executable path.

TODO

  • Basic tests
  • Refactor for both executable name and title once the umu-database is updated for executable names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant