Skip to content

[frontend]Change team creation/update to drawer(#3468) #3654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 30, 2025
Merged

[frontend]Change team creation/update to drawer(#3468) #3654

merged 3 commits into from
Sep 30, 2025

Conversation

@johanah29
Copy link
Member

No description provided.

@johanah29 johanah29 self-assigned this Jul 17, 2025
@johanah29 johanah29 linked an issue Jul 17, 2025 that may be closed by this pull request
Creation of team should be a drawer and not a dialog #3468
Closed
@codecov
Copy link

codecov bot commented Jul 17, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.15%. Comparing base (b040610) to head (4f56f86).
⚠️ Report is 201 commits behind head on release/current.

Additional details and impacted files 
@@                Coverage Diff                 @@
##             release/current    #3654   +/-   ##
==================================================
  Coverage              46.15%   46.15%           
  Complexity              2967     2967           
==================================================
  Files                    792      792           
  Lines                  23585    23585           
  Branches                1685     1685           
==================================================
  Hits                   10885    10885           
  Misses                 12074    12074           
  Partials                 626      626

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RomuDeuxfois
Copy link
Member

RomuDeuxfois commented Jul 21, 2025 •
edited
Loading

Buttons style is incorrect
image

@RomuDeuxfois
Copy link
Member

When I create a new team from the definition tab on a scenario I have this weird behavior
image

@johanah29
Copy link
Member Author

image

I do not have the same issue when trying to create a team in the definition tab

@johanah29
Copy link
Member Author

The buttons display is corrected in another PR dedicated to the correction of the buttons of all the forms of the platform

@johanah29 johanah29 requested a review from RomuDeuxfois July 21, 2025 13:54
@guillaumejparis guillaumejparis force-pushed the release/current branch 3 times, most recently from 91c898d to ca088d6 Compare July 28, 2025 12:54
@johanah29 johanah29 requested a review from RomuDeuxfois August 19, 2025 09:59
@johanah29 johanah29 merged commit 80f24c9 into release/current Sep 30, 2025
6 checks passed
@johanah29 johanah29 deleted the issue/3468 branch September 30, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RomuDeuxfois RomuDeuxfois RomuDeuxfois approved these changes

Assignees

@johanah29 johanah29

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Creation of team should be a drawer and not a dialog

3 participants

@johanah29 @RomuDeuxfois