-
Notifications
You must be signed in to change notification settings - Fork 165
[frontend] Implement Detection Remediation Rules by AI - Button UseAriane (Issue/3668 chunk 3) #4051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add comment properties file; - Add DTO Swagger description - Add API Swagger description - Use new project structure (Service: webservice (Response/Request) / API : restController (dto.Input/Output) - New method into EE to get encoded certificate EE - Add new generic class OkHttpClientUtils
- Add findAllByIdIn() to get Attack pattern list by ids - Update Model: DetectionRemediation; Add field authorRule and Enum AUTHOR_RULE(Human, AI) + TYPE enum in DB and Update DB with new column and default value 'HUMAN'; - Rename DetectionRemediationService to DetectionRemediationAIService and create another one DetectionRemediationService: separate roles DetectionRemediationAIService (call webservice) DetectionRemediationService (CRUD OpenAEV Model) - Add new API /rules/crowdstrike
…ules; add payload_collector_type_selected into input and generify api;
2520419
to
a9a72a2
Compare
a9a72a2
to
84dc059
Compare
# Conflicts: # openbas-api/src/main/java/io/openbas/api/detection_remediation/DetectionRemediationApi.java # openbas-api/src/main/java/io/openbas/collectors/utils/CollectorsUtils.java # openbas-api/src/main/java/io/openbas/service/detection_remediation/DetectionRemediationRequest.java # openbas-api/src/main/java/io/openbas/service/detection_remediation/DetectionRemediationService.java # openbas-front/src/utils/api-types.d.ts
… API : api/detection-remediations/ai/rules/inject/{injectId}/collector/{collectorType}; add static Collector name into CollectorsUtils; add method collectorByType into CollectorService to create DetectionRemediation linked to the colletor (collectors are created from external call OpenAEV/collector python); Generify creation of DetectionRemediationRequest using 2 differents constructor and a unique setPayload(...) ; # Conflicts: # openbas-api/src/main/java/io/openbas/api/detection_remediation/DetectionRemediationApi.java # openbas-api/src/main/java/io/openbas/collectors/utils/CollectorsUtils.java # openbas-api/src/main/java/io/openbas/service/detection_remediation/DetectionRemediationRequest.java # openbas-api/src/main/java/io/openbas/service/detection_remediation/DetectionRemediationService.java
…r updated remediation; update PayloadMapper method toDetectionRemediationOutput();
- Fix loading and AI rules status updates based on changes - Fix ESLint warnings and errors - Add payload type validation for Ariane usage - Implement snapshot context to persist remediation state
# Conflicts: # openbas-api/src/main/java/io/openbas/rest/collector/service/CollectorService.java # openbas-front/package.json # openbas-front/src/admin/components/payloads/PayloadForm.tsx # openbas-front/src/admin/components/payloads/form/RemediationFormTab.tsx # openbas-front/yarn.lock
EvaE-Filigran
approved these changes
Oct 1, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release/current #4051 +/- ##
=====================================================
- Coverage 47.62% 47.15% -0.47%
- Complexity 3266 3272 +6
=====================================================
Files 842 851 +9
Lines 25034 25302 +268
Branches 1814 1846 +32
=====================================================
+ Hits 11923 11932 +9
- Misses 12409 12667 +258
- Partials 702 703 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Testing Instructions
Follow Instruction chunk 1
Workflow concern:
2.1 Payload Creation
2.2 Payload Update
2.3 Rules generation by Inject : Atomic Testing
2.4 Rules generation by Inject : Simulation
Payload Type:
The table collector is populated by an external system: https://github.com/OpenAEV-Platform/collectors , depending on the collectors (EDR and SIEM) installed on your system. Note that the name of your CrowdStrike collector MUST BE "openbas_crowdstrike". An update of the collectors project is in progress to prevent modification of this name. On 30/09/2025, the names starting with "openbas_" will be updated to "openaev_".
Error Workflow 2.3 (Inject Atomic Testing) and 2.4 (Simulation):
Local : install Docker webservice: webservice.remediation.detection : https://github.com/FiligranHQ/remediation_detection_webservice
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...
download-macro-phishing.txt
activate-guest-account.txt
enable-guest-rdp-admin.txt