Skip to content

Conversation

camrrx
Copy link
Member

@camrrx camrrx commented Sep 26, 2025

Proposed changes

  • Protected the platform settings routes when the user does not have the right permissions

Testing Instructions

  1. Give platform settings access and manage permissions to a user
  2. Login to this user
  3. Go on platform settings and update his own role to remove access and manage platform settings right
  4. Refresh the page
  5. You should have the message "You don't have the right access..."

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@camrrx camrrx added the filigran team use to identify PR from the Filigran team label Sep 26, 2025
Copy link

codecov bot commented Sep 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.25%. Comparing base (fff140f) to head (4d3e78a).

Additional details and impacted files
@@                  Coverage Diff                  @@
##             release/current    #4093      +/-   ##
=====================================================
+ Coverage              47.23%   47.25%   +0.01%     
  Complexity              3252     3252              
=====================================================
  Files                    840      840              
  Lines                  25187    25187              
  Branches                1819     1819              
=====================================================
+ Hits                   11898    11901       +3     
+ Misses                 12592    12589       -3     
  Partials                 697      697              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@camrrx camrrx merged commit fc8ba01 into release/current Sep 29, 2025
10 checks passed
@camrrx camrrx deleted the issue/375-protected-platform-settings branch September 29, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants