Skip to content

Conversation

@damgouj
Copy link
Member

@damgouj damgouj commented Nov 20, 2025

Proposed changes

  • Fix documents for atomic testings (Back CRUD and Front bugs)

Testing Instructions

  1. Create an atomic testing "mail"
  2. Manage documents in it (add, update, remove,...)
  3. Execute the atomic test and check if you have documents attached in the mail received
  4. Relaunch the atomic testing and check like step 3.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

@damgouj damgouj changed the title [backend/frontend] fix: Fix documents for atomic testings (#3956) [backend/frontend] fix: Documents for atomic testings (#3956) Nov 20, 2025
@damgouj damgouj changed the title [backend/frontend] fix: Documents for atomic testings (#3956) [backend/frontend] fix: documents for atomic testings (#3956) Nov 20, 2025
@damgouj damgouj added the filigran team use to identify PR from the Filigran team label Nov 20, 2025
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.10%. Comparing base (5cf27f1) to head (aff068a).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../java/io/openaev/service/AtomicTestingService.java 87.50% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4394      +/-   ##
============================================
+ Coverage     49.87%   50.10%   +0.22%     
- Complexity     3612     3625      +13     
============================================
  Files           888      888              
  Lines         26491    26494       +3     
  Branches       1984     1986       +2     
============================================
+ Hits          13213    13275      +62     
+ Misses        12487    12426      -61     
- Partials        791      793       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@damgouj damgouj marked this pull request as ready for review November 24, 2025 07:29
@gabriel-peze gabriel-peze self-requested a review November 24, 2025 09:03
@gabriel-peze
Copy link
Contributor

Tested ok, but is it possible to add some test to avoid the decrease of test coverage ?

@damgouj damgouj requested a review from gabriel-peze November 25, 2025 10:18
@damgouj damgouj merged commit 78b91a8 into master Nov 25, 2025
12 checks passed
@damgouj damgouj deleted the issue/3956 branch November 25, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error 500 when relaunching Atomic testing / send individual mails with Attachment

4 participants