fix(app): warm up model at startup to avoid first-request connection errors - #392
Open
ousamabenyounes wants to merge 1 commit into
Open
fix(app): warm up model at startup to avoid first-request connection errors#392ousamabenyounes wants to merge 1 commit into
ousamabenyounes wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Load the VoxCPM model during server startup in run_demo() instead of lazily on the first request. The multi-GB from_pretrained ran inside the first click, blocking that request for minutes and surfacing any load/download failure as an opaque connection error (issue #367). Warming up before launch fails fast and keeps the first generation responsive.
Test verification (RED → GREEN)
With the fix reverted, the new test fails (RED):
With the fix applied, the test passes (GREEN):
Full local suite
Command:
python3 -m pytest tests/ -vFix #367