fix: limit step attention to active cache - #395
Open
ousamabenyounes wants to merge 1 commit into
Open
Conversation
Slice the static KV cache before SDPA so autoregressive steps only attend to populated positions and avoid a full-length boolean mask. Generated by Ora Studio Vibe coded by ousamabenyounes Co-Authored-By: Ora Agent <noreply@oratelecom.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #293.
Test verification (RED → GREEN)
The regression test intercepts the SDPA boundary, records the KV sequence
length and mask presence, and still calls the real PyTorch SDPA implementation.
With the new test on
upstream/main(production fix absent):With the production fix restored:
The production-only revert was repeated after implementation and reproduced
the same failure; restoring the patch returned the test to green.
Full local suite validation:
No local CUDA benchmark was run or claimed.