Skip to content

Monitor all temperature sensors #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Monitor all temperature sensors #922

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f001313
Monitor all temperature sensors
kimble4 Oct 25, 2024
c98e7f0
Merge branch 'master' into temperature-fix
jeremypoulter Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/evse_monitor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,11 +777,14 @@ void EvseMonitor::getTemperatureFromEvse()
if(_temps[i].isValid())
{
double temp = _temps[i].get();
_temps[EVSE_MONITOR_TEMP_MONITOR].set(temp);
if(temp > _temps[EVSE_MONITOR_TEMP_MAX].get()) {
if(!_temps[EVSE_MONITOR_TEMP_MONITOR].isValid() || temp > _temps[EVSE_MONITOR_TEMP_MONITOR].get())
{
_temps[EVSE_MONITOR_TEMP_MONITOR].set(temp);
}
if(temp > _temps[EVSE_MONITOR_TEMP_MAX].get())
Copy link

Copilot AI Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a validity check for _temps[EVSE_MONITOR_TEMP_MAX] (similar to the monitor sensor) before comparing the temperature. This could help avoid unexpected behavior if the max sensor’s value is uninitialized.

Suggested change
if(temp > _temps[EVSE_MONITOR_TEMP_MAX].get())
if(!_temps[EVSE_MONITOR_TEMP_MAX].isValid() || temp > _temps[EVSE_MONITOR_TEMP_MAX].get())

Copilot uses AI. Check for mistakes.

{
_temps[EVSE_MONITOR_TEMP_MAX].set(temp);
}
break;
}
}
_data_ready.ready(EVSE_MONITOR_TEMP_DATA_READY);
Expand Down
Loading