Polish -- parameter check, typos, imports

src/main/java/net/openhft/chronicle/bytes/AbstractBytes.java

@@ -207,7 +207,7 @@ public Bytes<U> clear()
     }
 
     /**
-     * Clears the buffer then advances both cursors by {@code length} bytes
+     * Clears the buffer and advances both cursors by {@code length} bytes
      * leaving space at the start.
      *
      * @throws BufferOverflowException if {@code start() + length > capacity()}

src/main/java/net/openhft/chronicle/bytes/AppendableUtil.java

@@ -62,7 +62,7 @@ public static void parseUtf8(@NotNull BytesStore<?, ?> bs, StringBuilder sb, boo
     }
 
     /**
-     * Adjusts the logical length of {@code sb}. For {@link Bytes} this moves the
+     * Adjusts the logical length of {@code sb}. For {@link Bytes} it moves the
      * write position to {@code newLength}.
      */
     public static void setLength(@NotNull Appendable sb, @NonNegative int newLength)

src/main/java/net/openhft/chronicle/bytes/algo/XxHash.java

@@ -132,10 +132,11 @@ public long applyAsLong(BytesStore<?, ?> bytes) {
      */
     @Override
     public long applyAsLong(BytesStore<?, ?> bytes, @NonNegative long length) throws IllegalStateException, BufferUnderflowException {
+        if (length < 0 || length > bytes.readRemaining())
+            throw new BufferUnderflowException();
+
         long hash;
         long remaining = length;
-        if (remaining < 0 || length > bytes.readRemaining())
-            throw new BufferUnderflowException();
         long off = bytes.readPosition();
 
         if (remaining >= 32) {

src/test/java/net/openhft/chronicle/bytes/BytesMarshallerTest.java

@@ -8,7 +8,6 @@
 import org.junit.jupiter.api.Test;
 
 import java.lang.reflect.Field;
-import java.util.Arrays;
 
 import static org.mockito.Mockito.*;
 import static org.junit.jupiter.api.Assertions.*;

src/test/java/net/openhft/chronicle/bytes/DistributedUniqueTimeProviderTest.java

@@ -74,7 +74,7 @@ public void currentTimeMicrosPerf() {
         } while ((end = System.currentTimeMillis()) < start + 500);
         long rate = 1000L * count / (end - start);
         System.out.printf("currentTimeMicrosPerf count/sec: %,d%n", rate);
-        assertTrue(count > 128_000 / 2); // half the speed of Rasberry Pi
+        assertTrue(count > 128_000 / 2); // half the speed of Raspberry Pi
     }
 
     @Test
@@ -88,7 +88,7 @@ public void currentTimeNanosPerf() {
         } while ((end = System.currentTimeMillis()) < start + 500);
         long rate = 1000L * count / (end - start);
         System.out.printf("currentTimeNanosPerf count/sec: %,d%n", rate);
-        assertTrue(count > 202_000 / 2); // half the speed of Rasberry Pi
+        assertTrue(count > 202_000 / 2); // half the speed of Raspberry Pi
     }
 
     @Test

src/test/java/net/openhft/chronicle/bytes/MappedBytesBoundaryTest.java

@@ -6,12 +6,10 @@
 import net.openhft.chronicle.bytes.internal.CommonMappedBytes;
 import net.openhft.chronicle.core.Jvm;
 import net.openhft.chronicle.core.OS;
-import net.openhft.chronicle.core.io.BackgroundResourceReleaser;
 import org.junit.Before;
 import org.junit.Test;
 
 import java.io.File;
-import java.io.FileNotFoundException;
 import java.io.IOException;
 import java.io.RandomAccessFile;
 import java.nio.BufferOverflowException;

src/test/java/net/openhft/chronicle/bytes/MappedBytesWrite8bitBoundaryTest.java

@@ -11,7 +11,6 @@
 import java.io.File;
 import java.io.IOException;
 import java.nio.charset.StandardCharsets;
-import java.nio.file.FileSystemException;
 import java.nio.file.Files;
 
 import static org.junit.Assert.assertEquals;

src/test/java/net/openhft/chronicle/bytes/MappedUniqueTimeProviderTest.java

@@ -65,7 +65,7 @@ public void currentTimeMillisPerf() {
             count += 1000;
         } while (System.currentTimeMillis() < start + 500);
         System.out.println("currentTimeMillisPerf count/sec: " + count * 2);
-        assertTrue(count > 1_000_000 / 2); // half the speed of Rasberry Pi
+        assertTrue(count > 1_000_000 / 2); // half the speed of Raspberry Pi
     }
 
     @Test
@@ -78,7 +78,7 @@ public void nanoTimePerf() {
             count += 1000;
         } while (System.currentTimeMillis() < start + 500);
         System.out.println("nanoTimePerf count/sec: " + count * 2);
-        assertTrue(count > 800_000 / 2); // half the speed of Rasberry Pi
+        assertTrue(count > 800_000 / 2); // half the speed of Raspberry Pi
     }
 
     @Test
@@ -92,7 +92,7 @@ public void currentTimeMicrosPerf() {
             count += 1000;
         } while (System.currentTimeMillis() < start + 500);
         System.out.println("currentTimeMicrosPerf count/sec: " + count * 2);
-        assertTrue(count > 230_000 / 2); // half the speed of Rasberry Pi
+        assertTrue(count > 230_000 / 2); // half the speed of Raspberry Pi
     }
 
     @Test
@@ -106,7 +106,7 @@ public void currentTimeNanosPerf() {
             count += 1000;
         } while (System.currentTimeMillis() < start + 500);
         System.out.println("currentTimeNanosPerf count/sec: " + count * 2);
-        assertTrue(count > 320_000 / 2); // half the speed of Rasberry Pi
+        assertTrue(count > 320_000 / 2); // half the speed of Raspberry Pi
     }
 
     @Test

src/test/java/net/openhft/chronicle/bytes/MethodReaderBuilderTest.java

@@ -7,7 +7,6 @@
 import org.junit.Before;
 import org.junit.Test;
 import org.mockito.Mockito;
-import java.util.function.Predicate;
 
 import static org.junit.Assume.assumeFalse;
 import static org.mockito.Mockito.*;

src/test/java/net/openhft/chronicle/bytes/UncheckedBytesTest.java

@@ -3,9 +3,6 @@
  */
 package net.openhft.chronicle.bytes;
 
-import net.openhft.chronicle.bytes.Bytes;
-import net.openhft.chronicle.bytes.BytesStore;
-import net.openhft.chronicle.bytes.UncheckedBytes;
 import net.openhft.chronicle.core.pool.ClassAliasPool;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;

src/test/java/net/openhft/chronicle/bytes/util/AbstractInternerTest.java

@@ -5,7 +5,6 @@
 
 import net.openhft.chronicle.bytes.Bytes;
 import net.openhft.chronicle.bytes.BytesStore;
-import net.openhft.chronicle.bytes.util.AbstractInterner;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;

src/test/java/net/openhft/chronicle/bytes/util/EscapingStopCharsTesterTest.java

@@ -6,7 +6,6 @@
 import net.openhft.chronicle.bytes.StopCharsTester;
 import org.junit.Test;
 import org.junit.Before;
-import static org.mockito.Mockito.*;
 import static org.junit.Assert.*;
 
 public class EscapingStopCharsTesterTest {